Sample policy files broken since 3.12.0

Bug #1975682 reported by Pierre Riteau
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.policy
Fix Released
Undecided
Unassigned

Bug Description

Sample policy files generated by oslopolicy-sample-generator using oslo.policy 3.12.0 or 3.12.1 are the same as those generated by oslopolicy-policy-generator.

Below is an example with CloudKitty.

3.11.0:

# Return the list of every services mapped to a collector.
# LIST /v1/collector/mappings
#"collector:list_mappings": "role:admin"

3.12.0:

"collector:list_mappings": "role:admin"

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.policy (master)
Changed in oslo.policy:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.policy (master)

Reviewed: https://review.opendev.org/c/openstack/oslo.policy/+/843250
Committed: https://opendev.org/openstack/oslo.policy/commit/5bd767be790f21d6ec0af0589f50137b207d94e8
Submitter: "Zuul (22348)"
Branch: master

commit 5bd767be790f21d6ec0af0589f50137b207d94e8
Author: Pierre Riteau <email address hidden>
Date: Wed May 25 11:04:33 2022 +0200

    Fix generation of sample policy files

    Generation of sample policy files was broken when exclude_deprecated was
    added as an extra argument to the generate_sample function in
    I6d02eb4d8f94323a806fab991ba2f1c3bbf71d04. It was passed as the fourth
    argument, which is actually include_help. Because it defaults to False,
    this turned sample policy files into actual policy files.

    Fix by using keyword arguments instead.

    Change-Id: I5478b1c8e7fd2f1b01f63602998194bab3683f7c
    Closes-Bug: #1975682

Changed in oslo.policy:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/oslo.policy 4.0.0

This issue was fixed in the openstack/oslo.policy 4.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers