policy file validation errors are hard to debug

[aeva black]

While adding new entries to Ironic's policy.json file, I had a typo in a line, but oslo_policy._parser() reports the error from other (correct) lines in the file.

Here's the traceback:

2016-06-02 15:16:03.463 24557 ERROR oslo_policy._parser [-] Failed to understand rule admin_or_ops
2016-06-02 15:16:03.463 24557 ERROR oslo_policy._parser Traceback (most recent call last):
2016-06-02 15:16:03.463 24557 ERROR oslo_policy._parser File "/opt/source/openstack/ironic/.tox/venv/lib/python3.
5/site-packages/oslo_policy/_parser.py", line 213, in _parse_check
2016-06-02 15:16:03.463 24557 ERROR oslo_policy._parser kind, match = rule.split(':', 1)
2016-06-02 15:16:03.463 24557 ERROR oslo_policy._parser ValueError: not enough values to unpack (expected 2, got 1)
2016-06-02 15:16:03.463 24557 ERROR oslo_policy._parser
2016-06-02 15:16:03.464 24557 ERROR oslo_policy._parser [-] Failed to understand rule admin_or_ops
2016-06-02 15:16:03.464 24557 ERROR oslo_policy._parser Traceback (most recent call last):
2016-06-02 15:16:03.464 24557 ERROR oslo_policy._parser File "/opt/source/openstack/ironic/.tox/venv/lib/python3.
5/site-packages/oslo_policy/_parser.py", line 213, in _parse_check
2016-06-02 15:16:03.464 24557 ERROR oslo_policy._parser kind, match = rule.split(':', 1)
2016-06-02 15:16:03.464 24557 ERROR oslo_policy._parser ValueError: not enough values to unpack (expected 2, got 1)

Here is my policy file. Note the error on the last line, not in the "admin_or_ops" rule.

{
    "default": "rule:admin_or_ops",
    "show_password": "!",
    "admin_api": "role:admin or role:administrator",
    "admin_or_ops": "role:admin or role:operator",
    "baremetal:node:list": "admin_or_ops"
}

[Morgan Fainberg (mdrnstm)]

Yes this is a real problem! I was helping devananda with debugging some things and ran across this.

[Kseniya Tychkova (ktychkova)]

Fix: https://review.openstack.org/#/c/341446/

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/oslo.policy 1.13.0 release.