Orphaned queues are not auto-deleted for Qpid

Bug #1374519 reported by Ihar Hrachyshka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Unassigned
Icehouse
Won't Fix
Undecided
Ihar Hrachyshka
oslo.messaging
Fix Released
Medium
Mehdi Abaakouk
Juno
Fix Released
Medium
Unassigned

Bug Description

The following patch incorrectly set auto-delete for Qpid to False: https://github.com/openstack/oslo-incubator/commit/5ff534d1#diff-372094c4bfc6319d22875a970aa6b730R190

While for RabbitMQ, it's True.

This results in queues left on the broker if client dies and does not return back.

Red Hat bug for reference: https://bugzilla.redhat.com/show_bug.cgi?id=1099657

Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

Neutron Icehouse is affected because it still uses oslo-incubator RPC layer. As for Juno+, it's not. [I can't set Icehouse milestone for the bug, so leaving as-is.]

Mehdi Abaakouk (sileht)
Changed in oslo.messaging:
assignee: nobody → Mehdi Abaakouk (sileht)
Changed in neutron:
importance: Undecided → Medium
status: New → Confirmed
milestone: none → 2014.1.3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (master)

Fix proposed to branch: master
Review: https://review.openstack.org/124741

Changed in oslo.messaging:
status: New → In Progress
Changed in neutron:
milestone: 2014.1.3 → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (master)

Reviewed: https://review.openstack.org/124741
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=1640cc17031bde765d7e272c2e65993c4b270a45
Submitter: Jenkins
Branch: master

commit 1640cc17031bde765d7e272c2e65993c4b270a45
Author: Mehdi Abaakouk <email address hidden>
Date: Fri Sep 26 22:28:17 2014 +0200

    qpid: Always auto-delete queue of DirectConsumer

    In case of the call()er die, the queue used to reply must be
    automatically deleted, otherwise they will never been deleted.

    This is done in the same way as the rabbit drivers does,
    by enabling auto-delete on this queue.

    Change-Id: Ib01981d704b8849e0115791ff90fbb74cbac421f
    Closes-Bug: #1374519

Changed in oslo.messaging:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/131675

Changed in neutron:
status: Confirmed → Fix Released
Mehdi Abaakouk (sileht)
Changed in oslo.messaging:
milestone: none → 1.5.0
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/163789

Changed in oslo.messaging:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (stable/juno)

Reviewed: https://review.openstack.org/163789
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=ec65803d478d8de525214b2cae722cb72d38b8c9
Submitter: Jenkins
Branch: stable/juno

commit ec65803d478d8de525214b2cae722cb72d38b8c9
Author: Mehdi Abaakouk <email address hidden>
Date: Fri Sep 26 22:28:17 2014 +0200

    qpid: Always auto-delete queue of DirectConsumer

    In case of the call()er die, the queue used to reply must be
    automatically deleted, otherwise they will never been deleted.

    This is done in the same way as the rabbit drivers does,
    by enabling auto-delete on this queue.

    Change-Id: Ib01981d704b8849e0115791ff90fbb74cbac421f
    Closes-Bug: #1374519
    (cherry picked from commit 1640cc17031bde765d7e272c2e65993c4b270a45)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on oslo.messaging (stable/icehouse)

Change abandoned by Ihar Hrachyshka (<email address hidden>) on branch: stable/icehouse
Review: https://review.openstack.org/131675
Reason: Icehouse is dying.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.