oslo.messaging

Tests fail with recent versions of kombu

Bug #1885923 reported by Stephen Finucane
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.messaging
Fix Released
High
Stephen Finucane

Bug Description

Running tests with versions of kombu > 4.6.8 results in time outs as the test hang waiting for a connection. This appears to be caused by [1]

[1] https://github.com/celery/kombu/pull/1193/commits/398aa5b8cd1fe1fc189ab35a2cb0bececf51bf37

Stephen Finucane (stephenfinucane)
Changed in oslo.messaging:
importance: Undecided → High
assignee: nobody → Stephen Finucane (stephenfinucane)
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (master)

Fix proposed to branch: master
Review: https://review.opendev.org/738850

Changed in oslo.messaging:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to oslo.messaging (master)

Reviewed: https://review.opendev.org/736248
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=7e406c312a6514e7ae377edb52b9e02b5bf37a7d
Submitter: Zuul
Branch: master

commit 7e406c312a6514e7ae377edb52b9e02b5bf37a7d
Author: Andreas Jaeger <email address hidden>
Date: Wed Jun 17 16:53:03 2020 +0200

    Simplify tools/test-setup.sh

    test-setup.sh is called after bindep is run in CI, and tox is not setup.

    Simplify the script so that it only does what's needed - install
    qdrouterd for Ubuntu from qpid/testing.

    Install the other packages using bindep, add test to amqp1 profile.

    Add amqp1 to bindep_profiles where needed for scenario tests, previously
    test-setup.sh added it everywhere.

    Some tests are skipped due to changes in recent versions of kombu. These
    will be unskipped when we come up with a proper fix.

    Change-Id: Ic3a9e2c873619670edfbf71022d593f3cb5f70f2
    Related-Bug: #1885923

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to oslo.messaging (stable/ussuri)

Related fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/738976

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to oslo.messaging (stable/ussuri)

Reviewed: https://review.opendev.org/738976
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=dfcc4b0010d39d1f16be413bb1c3a4808718cd19
Submitter: Zuul
Branch: stable/ussuri

commit dfcc4b0010d39d1f16be413bb1c3a4808718cd19
Author: Andreas Jaeger <email address hidden>
Date: Wed Jun 17 16:53:03 2020 +0200

    Simplify tools/test-setup.sh

    test-setup.sh is called after bindep is run in CI, and tox is not setup.

    Simplify the script so that it only does what's needed - install
    qdrouterd for Ubuntu from qpid/testing.

    Install the other packages using bindep, add test to amqp1 profile.

    Add amqp1 to bindep_profiles where needed for scenario tests, previously
    test-setup.sh added it everywhere.

    NOTE(elod.illes): skip annotation removed from test_impl_rabbit.py, as
    kombu is constrained in ussuri with the version that does not need any
    test to skip.

    Change-Id: Ic3a9e2c873619670edfbf71022d593f3cb5f70f2
    Related-Bug: #1885923
    (cherry picked from commit 7e406c312a6514e7ae377edb52b9e02b5bf37a7d)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to oslo.messaging (stable/train)

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/739060

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (master)

Reviewed: https://review.opendev.org/738850
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=afb035d97185fa9c622bdb9b4c31c71f01160370
Submitter: Zuul
Branch: master

commit afb035d97185fa9c622bdb9b4c31c71f01160370
Author: Stephen Finucane <email address hidden>
Date: Wed Jul 1 15:01:00 2020 +0100

    tests: Resolves issues with kombu > 4.6.8

    The 'kombu.connection.Connection.ensure_connection' method has changed
    from calling 'retry_over_time' on 'self.connect' to calling it on
    'self._connection_factory' [1], meaning our mocks are outdated. Address
    this change.

    [1] https://github.com/celery/kombu/pull/1193/commits/398aa5b8cd1fe1fc

    Change-Id: Ibbcf21a57ab1e3f90c21901296e5c088b645127c
    Signed-off-by: Stephen Finucane <email address hidden>
    Closes-Bug: #1885923

Changed in oslo.messaging:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to oslo.messaging (stable/train)

Reviewed: https://review.opendev.org/739060
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=88cf5aebef790ff40ab8ca7219d537ccfc54d12e
Submitter: Zuul
Branch: stable/train

commit 88cf5aebef790ff40ab8ca7219d537ccfc54d12e
Author: Andreas Jaeger <email address hidden>
Date: Wed Jun 17 16:53:03 2020 +0200

    Simplify tools/test-setup.sh

    test-setup.sh is called after bindep is run in CI, and tox is not setup.

    Simplify the script so that it only does what's needed - install
    qdrouterd for Ubuntu from qpid/testing.

    Install the other packages using bindep, add test to amqp1 profile.

    Add amqp1 to bindep_profiles where needed for scenario tests, previously
    test-setup.sh added it everywhere.

    Conflicts:
        .zuul.yaml

    NOTE(elod.illes): conflict is due to scenario rationalizing patch
    I0f86416623a0b718516147f0660b4df2b74cf867 is not present in Train.

    Change-Id: Ic3a9e2c873619670edfbf71022d593f3cb5f70f2
    Related-Bug: #1885923
    (cherry picked from commit 7e406c312a6514e7ae377edb52b9e02b5bf37a7d)
    (cherry picked from commit dfcc4b0010d39d1f16be413bb1c3a4808718cd19)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to oslo.messaging (stable/stein)

Related fix proposed to branch: stable/stein
Review: https://review.opendev.org/739265

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to oslo.messaging (stable/stein)

Reviewed: https://review.opendev.org/739265
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=c5d17905de32a29352a7ad31fd1c7dcde8887017
Submitter: Zuul
Branch: stable/stein

commit c5d17905de32a29352a7ad31fd1c7dcde8887017
Author: Andreas Jaeger <email address hidden>
Date: Wed Jun 17 16:53:03 2020 +0200

    Simplify tools/test-setup.sh

    test-setup.sh is called after bindep is run in CI, and tox is not setup.

    Simplify the script so that it only does what's needed - install
    qdrouterd for Ubuntu from qpid/testing.

    Install the other packages using bindep, add test to amqp1 profile.

    Add amqp1 to bindep_profiles where needed for scenario tests, previously
    test-setup.sh added it everywhere.

    Conflicts:
        .zuul.yaml
        bindep.txt
    Modified:
        tools/test-setup.sh

    NOTE(elod.illes): conflicts are due to the following patches are
    missing from Stein:
    * .zuul.yaml: I1874f96f78cb403e6f3a56a49cb83df40d531f8d
      (dropping py35 testing)
    * bindep.txt: I9fb56450346fca84bc1573fa5e9b6fe81c14e33a
      (messaging intermediaries update; the lack of this patch also
      requires the modification of test-setup.sh)

    Change-Id: Ic3a9e2c873619670edfbf71022d593f3cb5f70f2
    Related-Bug: #1885923
    (cherry picked from commit 7e406c312a6514e7ae377edb52b9e02b5bf37a7d)
    (cherry picked from commit dfcc4b0010d39d1f16be413bb1c3a4808718cd19)
    (cherry picked from commit 88cf5aebef790ff40ab8ca7219d537ccfc54d12e)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to oslo.messaging (stable/rocky)

Related fix proposed to branch: stable/rocky
Review: https://review.opendev.org/739490

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to oslo.messaging (stable/queens)

Related fix proposed to branch: stable/queens
Review: https://review.opendev.org/739922

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to oslo.messaging (stable/rocky)

Reviewed: https://review.opendev.org/739490
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=41a7da012e0f0df2a5ddb689897448fd02b6175c
Submitter: Zuul
Branch: stable/rocky

commit 41a7da012e0f0df2a5ddb689897448fd02b6175c
Author: Andreas Jaeger <email address hidden>
Date: Wed Jun 17 16:53:03 2020 +0200

    Simplify tools/test-setup.sh

    test-setup.sh is called after bindep is run in CI, and tox is not setup.

    Simplify the script so that it only does what's needed - install
    qdrouterd for Ubuntu from qpid/testing.

    Install the other packages using bindep, add test to amqp1 profile.

    Add amqp1 to bindep_profiles where needed for scenario tests, previously
    test-setup.sh added it everywhere.

    Change-Id: Ic3a9e2c873619670edfbf71022d593f3cb5f70f2
    Related-Bug: #1885923
    (cherry picked from commit 7e406c312a6514e7ae377edb52b9e02b5bf37a7d)
    (cherry picked from commit dfcc4b0010d39d1f16be413bb1c3a4808718cd19)
    (cherry picked from commit 88cf5aebef790ff40ab8ca7219d537ccfc54d12e)
    (cherry picked from commit c5d17905de32a29352a7ad31fd1c7dcde8887017)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to oslo.messaging (stable/queens)

Reviewed: https://review.opendev.org/739922
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=c46367dad2904cfd3ff1b9cd722a08820dd60218
Submitter: Zuul
Branch: stable/queens

commit c46367dad2904cfd3ff1b9cd722a08820dd60218
Author: Andreas Jaeger <email address hidden>
Date: Wed Jun 17 16:53:03 2020 +0200

    Simplify tools/test-setup.sh

    test-setup.sh is called after bindep is run in CI, and tox is not setup.

    Simplify the script so that it only does what's needed - install
    qdrouterd for Ubuntu from qpid/testing.

    Install the other packages using bindep, add test to amqp1 profile.

    Add amqp1 to bindep_profiles where needed for scenario tests, previously
    test-setup.sh added it everywhere.

    NOTE(elod.illes): docs target of tox is failing due to dulwich 0.20.2
    is installed, which shows syntax error in python 2. To solve this issue
    docs target now installs dependencies with upper constraints.
    Also replaced upper-constraints.txt url to the newer one.

    Conflicts:
        .zuul.yaml

    Change-Id: Ic3a9e2c873619670edfbf71022d593f3cb5f70f2
    Related-Bug: #1885923
    (cherry picked from commit 7e406c312a6514e7ae377edb52b9e02b5bf37a7d)
    (cherry picked from commit dfcc4b0010d39d1f16be413bb1c3a4808718cd19)
    (cherry picked from commit 88cf5aebef790ff40ab8ca7219d537ccfc54d12e)
    (cherry picked from commit c5d17905de32a29352a7ad31fd1c7dcde8887017)
    (cherry picked from commit 41a7da012e0f0df2a5ddb689897448fd02b6175c)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/742609

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/742857

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/742858

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/742859

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/742860

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.opendev.org/742862

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (stable/ussuri)

Reviewed: https://review.opendev.org/742609
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=6727be7890f64446f1658d79fac196d30b6f1a18
Submitter: Zuul
Branch: stable/ussuri

commit 6727be7890f64446f1658d79fac196d30b6f1a18
Author: Stephen Finucane <email address hidden>
Date: Wed Jul 1 15:01:00 2020 +0100

    tests: Resolves issues with kombu > 4.6.8

    The 'kombu.connection.Connection.ensure_connection' method has changed
    from calling 'retry_over_time' on 'self.connect' to calling it on
    'self._connection_factory' [1], meaning our mocks are outdated. Address
    this change.

    [1] https://github.com/celery/kombu/pull/1193/commits/398aa5b8cd1fe1fc

    Change-Id: Ibbcf21a57ab1e3f90c21901296e5c088b645127c
    Signed-off-by: Stephen Finucane <email address hidden>
    Closes-Bug: #1885923
    (cherry picked from commit afb035d97185fa9c622bdb9b4c31c71f01160370)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on oslo.messaging (stable/rocky)

Change abandoned by Jan Zerebecki (<email address hidden>) on branch: stable/rocky
Review: https://review.opendev.org/742859
Reason: Abandoning because of resistance. I only need it in Ussuri. feel free to reopen.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on oslo.messaging (stable/queens)

Change abandoned by Jan Zerebecki (<email address hidden>) on branch: stable/queens
Review: https://review.opendev.org/742860
Reason: Abandoning because of resistance. I only need it in Ussuri. feel free to reopen.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on oslo.messaging (stable/stein)

Change abandoned by Jan Zerebecki (<email address hidden>) on branch: stable/stein
Review: https://review.opendev.org/742858
Reason: Abandoning because of resistance. I only need it in Ussuri. feel free to reopen.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on oslo.messaging (stable/train)

Change abandoned by Jan Zerebecki (<email address hidden>) on branch: stable/train
Review: https://review.opendev.org/742857
Reason: Abandoning because of resistance. I only need it in Ussuri. feel free to reopen.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on oslo.messaging (stable/pike)

Change abandoned by Jan Zerebecki (<email address hidden>) on branch: stable/pike
Review: https://review.opendev.org/742862
Reason: Abandoning because of resistance. I only need it in Ussuri. feel free to reopen.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.