Don't log exception for special non-existing methods

Bug #1857319 reported by Oleg Bondarev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.messaging
Fix Released
Undecided
Oleg Bondarev

Bug Description

Some systems may want to check openstack services readiness/liveness by sending some "health probe" RPC messages. However not all services do support such health probe methods in their RPC API.
So for example current implementation of probes in openstack-helm/neutron charts calls a non-existing RPC API on the agents and parses the output for NoSuchMethod error.
While working OK, it fills logs of pods with errors.

The proposal is to check method name and not log errors in case name ends with 'ignore_errors'.
This small handler on oslo.messaging side will let avoid changes in multiple services.

Changed in oslo.messaging:
assignee: nobody → Oleg Bondarev (obondarev)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (master)

Fix proposed to branch: master
Review: https://review.opendev.org/700384

Changed in oslo.messaging:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (master)

Reviewed: https://review.opendev.org/700384
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=d7eb89eac8f76c46849f5e0d18a7ea00dc2d07bb
Submitter: Zuul
Branch: master

commit d7eb89eac8f76c46849f5e0d18a7ea00dc2d07bb
Author: Oleg Bondarev <email address hidden>
Date: Mon Dec 23 11:32:28 2019 +0400

    Don't log NoSuchMethod for special non-existing methods

    Such non-existing methods are used as health probes.
    Please see bug for details.

    Change-Id: I8f6b4a669ec11721f76cf03abcd7d802c3c11eb5
    Closes-Bug: #1857319

Changed in oslo.messaging:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/oslo.messaging 11.0.0

This issue was fixed in the openstack/oslo.messaging 11.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/753526

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on oslo.messaging (stable/rocky)

Change abandoned by zhen (<email address hidden>) on branch: stable/rocky
Review: https://review.opendev.org/753526

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.