[AMQP 1.0] adopt the proper file layout

Bug #1579823 reported by Ken Giusti
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.messaging
Fix Released
Undecided
Ken Giusti

Bug Description

Other drivers have been added since the AMQP 1.0 driver was proposed. Since then the driver source filesystem layout has adopted the following structure where XXX is the driver's name (e.g. "pika"):

oslo_messaging/_drivers/impl_XXX.py
oslo_messaging/_drivers/XXX_driver/ # driver XXX files

The AMQP 1.0 driver does not conform to this, having its files hidden under the protocols/amqp directory.

The AMQP 1.0 drivers sources need to be re-organized to reflect the common convention.

Ken Giusti (kgiusti)
Changed in oslo.messaging:
assignee: nobody → Ken Giusti (kgiusti)
Ken Giusti (kgiusti)
Changed in oslo.messaging:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (master)

Reviewed: https://review.openstack.org/314218
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=e72a8d5bc4dcbd6542658ea9617ed04ea44673eb
Submitter: Jenkins
Branch: master

commit e72a8d5bc4dcbd6542658ea9617ed04ea44673eb
Author: Kenneth Giusti <email address hidden>
Date: Mon May 9 12:56:02 2016 -0400

    Reorganize the AMQP 1.0 driver source files

    This patch simply moves the existing AMQP 1.0 driver files into a
    directory layout that is consistent with the other drivers. The
    driver unit tests are also moved to the proper test directory. There
    are no changes in driver functionality or API.

    Change-Id: I83a5d5433be8c3b317597100af69192ec5be81f1
    Closes-Bug: #1579823

Changed in oslo.messaging:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (feature/amqp-dispatch-router)

Fix proposed to branch: feature/amqp-dispatch-router
Review: https://review.openstack.org/319440

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on oslo.messaging (feature/amqp-dispatch-router)

Change abandoned by Ken Giusti (<email address hidden>) on branch: feature/amqp-dispatch-router
Review: https://review.openstack.org/319440
Reason: No this needs to be merged not cherry-picked.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/oslo.messaging 5.2.0

This issue was fixed in the openstack/oslo.messaging 5.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (feature/amqp-dispatch-router)

Fix proposed to branch: feature/amqp-dispatch-router
Review: https://review.openstack.org/325916

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (feature/amqp-dispatch-router)
Download full text (6.9 KiB)

Reviewed: https://review.openstack.org/325916
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=1c7ff9d60ae82bc3016503c7eb3bcdc0e228fcfc
Submitter: Jenkins
Branch: feature/amqp-dispatch-router

commit 2668177256e2c09f2db69d026655e94045c20e5f
Author: Edan David <email address hidden>
Date: Thu Jun 2 01:42:01 2016 -0400

    Fix typo: 'olso' to 'oslo'

    Change-Id: Ic86ded995ecf24b094b25c140da264526eafe611

commit a620319af4583925f02b4b14d3c5106b85726dad
Author: OpenStack Proposal Bot <email address hidden>
Date: Thu Jun 2 04:08:22 2016 +0000

    Updated from global requirements

    Change-Id: Idb293b41afef83871ebfdb451f7f6a079ce10711

commit 31691745d43be5ea74772a8a2e4072616fdf0814
Author: ozamiatin <email address hidden>
Date: Mon May 16 15:43:27 2016 +0300

    [zmq] Don't skip non-direct message types

    If using the router proxy we need to be able to
    dispatch all types of messages over the routers,
    not limiting them to direct types only.

    Also added fanout possibility to do on a client-side,
    so we can reduce latency on a proxy, and not using
    pub-sub for fanout when we don't want it.

    Change-Id: Ic88c306c1d386dd582cbccfc5719fba5668a9db8

commit 8ee19159d2aa00e175bbdadac7d0d52627334cb5
Author: ozamiatin <email address hidden>
Date: Mon May 16 17:07:30 2016 +0300

    [zmq] Refactoring of zmq client

    Split ZmqClient in order to create different clients
    for different configurations (direct/proxy).

    Change-Id: Ib374f62f53f2c82278ce5bc555ea440e8eba6617

commit 4b0e247d2d9d1c8eb5b9f904dd632bda9c706670
Author: OpenStack Proposal Bot <email address hidden>
Date: Tue May 31 03:05:21 2016 +0000

    Updated from global requirements

    Change-Id: I5e48d3f427128c6beebdd04ec9dbfc96683cee9e

commit 9d51fa4a2fa734e347be1998f5fd2b1e35dbc0a4
Author: Andrew Smith <email address hidden>
Date: Thu May 26 11:54:29 2016 -0400

    [AMQP 1.0] Randomize host list connection attempts

    Randomize the initial selection of the host list for amqp 1.0 connection
    attempts.

    This patch:
    * randomizes initial index
    * updates failover unit tests

    Change-Id: Iab5ae684a2cd8ec0c6d0c59ffffde5eb5baf883b

commit 5fb8f269e7c03fe8252cf09dccb88ad64cc43e88
Author: JiaJunsu <email address hidden>
Date: Mon May 16 06:03:07 2016 -0700

    Modify the TransportURL's docstrings

    To match the test_urls.TestParseURL multi_creds

    Change-Id: I4a37b7bce3703aa581bc46d41690bf7978f813a6
    Close-Bug: #1529310

commit 9ccfbdd3c3b19419c370b041c0f39be6b70b622d
Author: Gevorg Davoian <email address hidden>
Date: Tue May 24 12:32:11 2016 +0300

    Fix problems after refactoring RPC client

    The patch fixes some problems arised after merging the previous
    patch which this patch depends on.

    Change-Id: If38edec19f9bffc8ac54818b2536243a9edaf7e8
    Depends-On: I608c828123b196099933d16801f8ce7d9dd3a079
    Closes-Bug: #1584889

commit 4d0f7ab652416af78e1e23d62235e868c4d1e57a
Author: Mehdi Abaakouk <email address hidden>
Date: Wed May 6 09:55:23 2015 +0200

    deprecate usage ...

Read more...

tags: added: in-feature-amqp-dispatch-router
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/oslo.messaging 5.3.0

This issue was fixed in the openstack/oslo.messaging 5.3.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.