[zmq] Don't use assertions in receive message

[Oleksii Zamiatin]

When consumer receives wrong message (message format is broken or unsupported)
correct behavior is to report an error and drop the message rather than server side unrecoverable failure (which assertions currently may cause).

Fix the logic, stick to the behavior described above.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/309334

[OpenStack Infra (hudson-openstack)]

Change abandoned by Oleksii Zamiatin (<email address hidden>) on branch: master
Review: https://review.openstack.org/309334
Reason: Fixed in another patch

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/308653
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=b5955b6ca938bfccfeefb37062bb5ff81c8895a4
Submitter: Jenkins
Branch: master

commit b5955b6ca938bfccfeefb37062bb5ff81c8895a4
Author: ozamiatin <email address hidden>
Date: Thu Apr 21 01:06:39 2016 +0300

    [zmq] Redesign router proxy

    In this change router was redesigned in a way most
    appropriate for routing concept of zmq.ROUTER socket.

    DEALER(cli)-ROUTER(proxy)-DEALER(srv) instead of
    DEALER-ROUTER-DEALER-ROUTER (3 layers instead of 4)

    The main reason is to use zmq.DEALER identity in message
    routing. For this reason DealerConsumer was introduced
    server-side. RouterConsumer is left for peer-to-peer
    DEALER-ROUTER deployment option.

    Also handled assertions in receive-methods in order
    to not stop server when received message with wrong format.

    Change-Id: If25edf500fa8d220d4233bb13d67121824e841c6
    Closes-Bug: #1558601
    Related-Bug: #1555007

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/oslo.messaging 5.1.0 release.