rabbitmq: unit conversion error of expiration

[javeme]

When sending a basic.publish, as the doc says[1]:
"The value of the expiration field describes the TTL period in milliseconds",
but kombu has already made a conversion from seconds to milliseconds[2], so
we do not need to do it again in oslo_messaging/_drivers/impl_rabbit.py[3].

[1]: http://www.rabbitmq.com/ttl.html#per-message-ttl
[2]: https://github.com/celery/kombu/blob/master/kombu/messaging.py#L152
     https://github.com/celery/kombu/blob/master/kombu/messaging.py#L169
[3]: https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/impl_rabbit.py#L983

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/263712

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/263712
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=d49ddc3b9828f097d5bb39bca0381386a9de7762
Submitter: Jenkins
Branch: master

commit d49ddc3b9828f097d5bb39bca0381386a9de7762
Author: Javeme <email address hidden>
Date: Tue Jan 5 20:05:10 2016 +0800

    rabbit: fix unit conversion error of expiration

    kombu has already made a conversion from seconds to milliseconds,
    so we do not need to do it again.

    Closes-Bug: #1531148
    Change-Id: Ia4478f15f1980a93a53f7e1e6570f68aeec75c69

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/265843

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/265843
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=9f986a71916e4b48515c254c33cd1d1e80194252
Submitter: Jenkins
Branch: stable/liberty

commit 9f986a71916e4b48515c254c33cd1d1e80194252
Author: Javeme <email address hidden>
Date: Tue Jan 5 20:05:10 2016 +0800

    rabbit: fix unit conversion error of expiration

    kombu has already made a conversion from seconds to milliseconds,
    so we do not need to do it again.

    Closes-Bug: #1531148
    Change-Id: Ia4478f15f1980a93a53f7e1e6570f68aeec75c69
    (cherry picked from commit d49ddc3b9828f097d5bb39bca0381386a9de7762)

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/oslo.messaging 4.1.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/281690

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/281690
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=9cfaf50c45cf82f102f157655359e9705dc5733c
Submitter: Jenkins
Branch: master

commit 9cfaf50c45cf82f102f157655359e9705dc5733c
Author: ChangBo Guo(gcb) <email address hidden>
Date: Thu Feb 18 16:12:56 2016 +0800

    Fix kombu accept different TTL since version 3.0.25

    kombu accept TTL as seconds instead of millisecond since version 3.0.25,
    We remove TTL conversion in commit d49ddc3b9828f097d5bb39bca0381386a9de7762,
    which is valid only when kombu >=3.0.25, so need do conversion according
    to kombu version.

    Note: Remove this workaround when all supported branches with
    requirement kombu >=3.0.25

    Closes-Bug: #1531148
    Change-Id: I762265f23084a95f2d24cb434bad7d9556d4edd5

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/282175

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/282175
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=ee46dda59f605f721c9b31641d1950c454856131
Submitter: Jenkins
Branch: stable/liberty

commit ee46dda59f605f721c9b31641d1950c454856131
Author: ChangBo Guo(gcb) <email address hidden>
Date: Thu Feb 18 16:12:56 2016 +0800

    Fix kombu accept different TTL since version 3.0.25

    kombu accept TTL as seconds instead of millisecond since version 3.0.25,
    We remove TTL conversion in commit d49ddc3b9828f097d5bb39bca0381386a9de7762,
    which is valid only when kombu >=3.0.25, so need do conversion according
    to kombu version.

    Note: Remove this workaround when all supported branches with
    requirement kombu >=3.0.25

    Closes-Bug: #1531148
    Change-Id: I762265f23084a95f2d24cb434bad7d9556d4edd5
    (cherry picked from commit 9cfaf50c45cf82f102f157655359e9705dc5733c)

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/oslo.messaging 4.4.0 release.