there is no public base class for notifier drivers

Bug #1426046 reported by Doug Hellmann
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
oslo.messaging
Fix Released
Wishlist
Davanum Srinivas (DIMS)

Bug Description

While investigating a request for help with creating a custom notification driver [1], I noticed that even the base class for those drivers is private. We should provide some information about how to create your own notifier, and making the base class public seems like one easy way to start. We should also describe it explicitly in the documentation, maybe using the docstring for the driver base class.

[1] http://lists.openstack.org/pipermail/openstack-dev/2015-February/057880.html

Tags: doc
Mehdi Abaakouk (sileht)
Changed in oslo.messaging:
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
Boden R (boden) wrote :

Is this just a matter of making the classes "public" or are you thinking the driver interface needs more thought + solidifying before making something extendable?

... Perhaps I can donate a cycle or 2 to get this in.

tags: added: doc
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (master)

Fix proposed to branch: master
Review: https://review.openstack.org/227374

Changed in oslo.messaging:
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (master)

Reviewed: https://review.openstack.org/227374
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=1893c495f6e9ba53c7d93ad99f679f44f66837ef
Submitter: Jenkins
Branch: master

commit 1893c495f6e9ba53c7d93ad99f679f44f66837ef
Author: Davanum Srinivas <email address hidden>
Date: Thu Sep 24 11:20:35 2015 -0400

    Allow custom notification drivers

    Our class hierarchy hides classes and modules that so its hard
    for folks to write a custom Notification driver. We should
    make these public and document them

    Closes-Bug: #1426046
    Change-Id: Ifb96c2ae9868426cac2700bf4917c27c02c90b15

Changed in oslo.messaging:
status: In Progress → Fix Committed
Changed in oslo.messaging:
milestone: none → 2.6.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.