py33 jobs fail sometimes

[Mehdi Abaakouk]

Hi,

Sometimes the py33 jobs fail with:

2015-01-14 16:12:06.182 | Traceback (most recent call last):
2015-01-14 16:12:06.182 | testtools.testresult.real._StringException: Empty attachments:
2015-01-14 16:12:06.182 | stderr
2015-01-14 16:12:06.182 | stdout
2015-01-14 16:12:06.182 |
2015-01-14 16:12:06.182 | Traceback (most recent call last):
2015-01-14 16:12:06.182 | File "/home/jenkins/workspace/gate-oslo.messaging-python33/oslo_messaging/tests/notify/test_listener.py", line 391, in test_two_pools_three_listener
2015-01-14 16:12:06.182 | self.assertLessEqual(25, endpoint2.info.call_count)
2015-01-14 16:12:06.182 | File "/home/jenkins/workspace/gate-oslo.messaging-python33/.tox/py33/lib/python3.3/site-packages/unittest2/case.py", line 1224, in assertLessEqual
2015-01-14 16:12:06.183 | self.fail(self._formatMessage(msg, standardMsg))
2015-01-14 16:12:06.183 | File "/home/jenkins/workspace/gate-oslo.messaging-python33/.tox/py33/lib/python3.3/site-packages/unittest2/case.py", line 666, in fail
2015-01-14 16:12:06.183 | raise self.failureException(msg)
2015-01-14 16:12:06.183 | AssertionError: 25 not less than or equal to 24
2015-01-14 16:12:06.183 |
2015-01-14 16:12:06.183 | Traceback (most recent call last):
2015-01-14 16:12:06.183 | testtools.testresult.real._StringException: Empty attachments:
2015-01-14 16:12:06.183 | stderr
2015-01-14 16:12:06.183 | stdout
2015-01-14 16:12:06.183 |
2015-01-14 16:12:06.183 | Traceback (most recent call last):
2015-01-14 16:12:06.183 | File "/home/jenkins/workspace/gate-oslo.messaging-python33/oslo_messaging/tests/notify/test_listener.py", line 391, in test_two_pools_three_listener
2015-01-14 16:12:06.184 | self.assertLessEqual(25, endpoint2.info.call_count)
2015-01-14 16:12:06.184 | File "/home/jenkins/workspace/gate-oslo.messaging-python33/.tox/py33/lib/python3.3/site-packages/unittest2/case.py", line 1224, in assertLessEqual
2015-01-14 16:12:06.184 | self.fail(self._formatMessage(msg, standardMsg))
2015-01-14 16:12:06.184 | File "/home/jenkins/workspace/gate-oslo.messaging-python33/.tox/py33/lib/python3.3/site-packages/unittest2/case.py", line 666, in fail
2015-01-14 16:12:06.184 | raise self.failureException(msg)
2015-01-14 16:12:06.184 | AssertionError: 25 not less than or equal to 24
2015-01-14 16:12:06.184 | Ran 3534 tests in 20.419s
2015-01-14 16:12:06.184 | FAILED (id=0, failures=1, skips=189)
2015-01-14 16:12:06.184 | error: testr failed (1)
2015-01-14 16:12:06.237 | ERROR: InvocationError: '/home/jenkins/workspace/gate-oslo.messaging-python33/.tox/py33/bin/python setup.py testr --slowest --testr-args='

see: http://logs.openstack.org/72/146872/2/gate/gate-oslo.messaging-python33/ace5695/console.html

Cheers,

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/145798
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=b888ee3ebf46b008dada1e825b24badb7053d7e8
Submitter: Jenkins
Branch: master

commit b888ee3ebf46b008dada1e825b24badb7053d7e8
Author: Mehdi Abaakouk <email address hidden>
Date: Thu Jan 8 14:26:45 2015 +0100

    Fixes test_two_pools_three_listener

    The Notification Listener Tracker class is not threadsafe,
    so when a test stop an already stopped listener this one
    can be restarted, due to concurrency access of the threads list and
    concurrency execution of the start/stop/wait method of the notification
    listener.
    This result of a lockup of the test or a listener can continue to
    got unepxected message.

    This change fixes that by never stop the tread with the tracker callback
    but only manually with the test.

    This test also rename some 'Listener' to 'Server', to not mismatch
    the driver listener from the notification listener.

    Closes-bug: #1410902

    Change-Id: I4777c7dd0ba71c61850d36641e85f33f9461e9c1