Running tests randomly hang

Bug #1409899 reported by Victor Stinner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.messaging
Fix Released
High
Victor Stinner

Bug Description

Hi,

When running tests with the master branch of Oslo Messaging, I randomly get hang. I'm using "tox -e py27", or "testr run" in the virtualenv.

According to Mehdi, it's an issue with qpid and eventlet monkey patch. In short, eventlet monkey patching must be enabled before the qpid module is loaded. Currently, depending on the execution order of tests, eventlet monkey patching may be enabled before or after importing the qpid module.

Monkey patching is enabled in two places:

oslo/messaging/_cmd/zmq_receiver.py:18:eventlet.monkey_patch()
tests/drivers/test_impl_zmq.py:32: eventlet.monkey_patch()

Changed in oslo.messaging:
assignee: nobody → Victor Stinner (victor-stinner)
status: New → In Progress
Ben Nemec (bnemec)
Changed in oslo.messaging:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (master)

Reviewed: https://review.openstack.org/146574
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=bc8675afb067c517cbe5ee1129aad080282bd7c4
Submitter: Jenkins
Branch: master

commit bc8675afb067c517cbe5ee1129aad080282bd7c4
Author: Victor Stinner <email address hidden>
Date: Mon Jan 12 16:58:32 2015 +0000

    fix qpid test issue with eventlet monkey patching

    Tests now ensure that eventlet monkey patching is enabled before
    importing the qpid module, otherwise qpid will hang.

    Currently, qpid randomly hangs, depending on the order of the Python
    module import, which probably depends on the local file modification
    time.

    Closes-Bug: #1409899
    Change-Id: I516c580faef04f55fcc095d22adbfabcfa001da7

Changed in oslo.messaging:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (master)

Fix proposed to branch: master
Review: https://review.openstack.org/147512

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (master)

Reviewed: https://review.openstack.org/147512
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=be9fca7f6f85cf1760345d1f56299aab99a89ef4
Submitter: Jenkins
Branch: master

commit be9fca7f6f85cf1760345d1f56299aab99a89ef4
Author: Mehdi Abaakouk <email address hidden>
Date: Thu Jan 15 14:57:30 2015 +0100

    fix qpid test issue with eventlet monkey patching

    I516c580faef04f55fcc095d22adbfabcfa001da7 have been
    merged just after the namespace change patch, but change only
    the old test directory.

    So reapply I516c580faef04f55fcc095d22adbfabcfa001da7 to the
    new test directory.

    Change-Id: I5cd7d7b6c507967e7fb4744012b2ad215c4f1ad3
    Closes-Bug: #1409899

Changed in oslo.messaging:
milestone: none → 1.6.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.