sporadic failure of : tests.drivers.test_impl_rabbit.TestRabbitTransportURL.test_transport_url(none)

[Mehdi Abaakouk]

Hi,

Sometime tests fail with:

2014-11-28 14:08:07.158 | FAIL: tests.drivers.test_impl_rabbit.TestRabbitTransportURL.test_transport_url(none)
2014-11-28 14:08:07.158 | tags: worker-6
2014-11-28 14:08:07.158 | ----------------------------------------------------------------------
2014-11-28 14:08:07.158 | Traceback (most recent call last):
2014-11-28 14:08:07.158 | File "/home/jenkins/workspace/gate-oslo.messaging-python26/.tox/py26/lib/python2.6/site-packages/mock.py", line 1201, in patched
2014-11-28 14:08:07.158 | return func(*args, **keywargs)
2014-11-28 14:08:07.158 | File "/home/jenkins/workspace/gate-oslo.messaging-python26/tests/drivers/test_impl_rabbit.py", line 164, in test_transport_url
2014-11-28 14:08:07.158 | self.assertEqual(sorted(self.expected), sorted(urls))
2014-11-28 14:08:07.158 | File "/home/jenkins/workspace/gate-oslo.messaging-python26/.tox/py26/lib/python2.6/site-packages/testtools/testcase.py", line 348, in assertEqual
2014-11-28 14:08:07.158 | self.assertThat(observed, matcher, message)
2014-11-28 14:08:07.158 | File "/home/jenkins/workspace/gate-oslo.messaging-python26/.tox/py26/lib/python2.6/site-packages/testtools/testcase.py", line 433, in assertThat
2014-11-28 14:08:07.159 | raise mismatch_error
2014-11-28 14:08:07.159 | MismatchError: ['amqp://guest:guest@localhost:5672//'] != ['memory:////']
2014-11-28 14:08:07.159 | Traceback (most recent call last):
2014-11-28 14:08:07.159 | _StringException: Empty attachments:
2014-11-28 14:08:07.159 | stderr
2014-11-28 14:08:07.159 | stdout
2014-11-28 14:08:07.159 |
2014-11-28 14:08:07.159 | Traceback (most recent call last):
2014-11-28 14:08:07.159 | File "/home/jenkins/workspace/gate-oslo.messaging-python26/.tox/py26/lib/python2.6/site-packages/mock.py", line 1201, in patched
2014-11-28 14:08:07.159 | return func(*args, **keywargs)
2014-11-28 14:08:07.159 | File "/home/jenkins/workspace/gate-oslo.messaging-python26/tests/drivers/test_impl_rabbit.py", line 164, in test_transport_url
2014-11-28 14:08:07.160 | self.assertEqual(sorted(self.expected), sorted(urls))
2014-11-28 14:08:07.160 | File "/home/jenkins/workspace/gate-oslo.messaging-python26/.tox/py26/lib/python2.6/site-packages/testtools/testcase.py", line 348, in assertEqual
2014-11-28 14:08:07.160 | self.assertThat(observed, matcher, message)
2014-11-28 14:08:07.160 | File "/home/jenkins/workspace/gate-oslo.messaging-python26/.tox/py26/lib/python2.6/site-packages/testtools/testcase.py", line 433, in assertThat
2014-11-28 14:08:07.160 | raise mismatch_error
2014-11-28 14:08:07.160 | MismatchError: ['amqp://guest:guest@localhost:5672//'] != ['memory:////']
2014-11-28 14:08:07.160 |
2014-11-28 14:08:07.160 | Traceback (most recent call last):
2014-11-28 14:08:07.160 | _StringException: Empty attachments:
2014-11-28 14:08:07.160 | stderr
2014-11-28 14:08:07.160 | stdout
2014-11-28 14:08:07.160 |
2014-11-28 14:08:25.590 | Traceback (most recent call last):
2014-11-28 14:08:25.590 | File "/home/jenkins/workspace/gate-oslo.messaging-python26/.tox/py26/lib/python2.6/site-packages/mock.py", line 1201, in patched
2014-11-28 14:08:25.590 | return func(*args, **keywargs)
2014-11-28 14:08:25.590 | File "/home/jenkins/workspace/gate-oslo.messaging-python26/tests/drivers/test_impl_rabbit.py", line 164, in test_transport_url
2014-11-28 14:08:25.590 | self.assertEqual(sorted(self.expected), sorted(urls))
2014-11-28 14:08:25.590 | File "/home/jenkins/workspace/gate-oslo.messaging-python26/.tox/py26/lib/python2.6/site-packages/testtools/testcase.py", line 348, in assertEqual
2014-11-28 14:08:25.590 | self.assertThat(observed, matcher, message)
2014-11-28 14:08:25.590 | File "/home/jenkins/workspace/gate-oslo.messaging-python26/.tox/py26/lib/python2.6/site-packages/testtools/testcase.py", line 433, in assertThat
2014-11-28 14:08:25.590 | raise mismatch_error
2014-11-28 14:08:25.591 | MismatchError: ['amqp://guest:guest@localhost:5672//'] != ['memory:////']
2014-11-28 14:08:25.591 | Ran 1753 tests in 21.073s
2014-11-28 14:08:25.591 | FAILED (id=0, failures=1, skips=39)
2014-11-28 14:08:25.591 | error: testr failed (1)
2014-11-28 14:08:25.644 | ERROR: InvocationError: '/home/jenkins/workspace/gate-oslo.messaging-python26/.tox/py26/bin/python setup.py testr --slowest --testr-args='

Cheers,

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/138029
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=f3370da11a867bae287d7f549a671811e8b399ef
Submitter: Jenkins
Branch: master

commit f3370da11a867bae287d7f549a671811e8b399ef
Author: Mehdi Abaakouk <email address hidden>
Date: Mon Dec 1 11:11:05 2014 +0100

    Don't share connection pool between driver object

    Each driver instance must use it's own connection pool.

    This removes the last global state of qpid and rabbitmq driver
    Make the relation between classes more simple.

    The previous behavior was not very safe, as explained in the bug report.

    And also, this is a first step to replace this custom connection pool
    handling by the kombu one.

    Closes bug: #1397925
    Partial bug: #1397339

    Change-Id: Iecd2b39c76417d9ac081d46810f72eb6e38edfda

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/138048
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=bcb3b23b8f6e7d01e38fdc031982558711bb7586
Submitter: Jenkins
Branch: master

commit bcb3b23b8f6e7d01e38fdc031982558711bb7586
Author: Mehdi Abaakouk <email address hidden>
Date: Mon Dec 1 11:28:13 2014 +0100

    Don't use oslo.cfg to set kombu in-memory driver

    This removes a TODO and also fixes a issue due to the
    global state of oslo.config.cfg.CONF.

    Closes bug: #1397339

    Change-Id: Ib366f35678f899fda93821e6f07897baf8f631b4