amqpdriver connection pool doesn't work

[Alexei Kornienko]

In https://github.com/openstack/oslo.messaging/blob/1.3.0/oslo/messaging/_drivers/amqpdriver.py#L337

we set pooled=False if we have some server_params set.

In init we have https://github.com/openstack/oslo.messaging/blob/1.3.0/oslo/messaging/_drivers/amqpdriver.py#L298
it means that it's always set and connection pool is efficiently useless.

[Mehdi Abaakouk (sileht)]

This have already been fixed in master

It was the desired behavior until the ConnectionPool object can handle multiple connection object.

Not sure it's really a bug, even you want to backport the connection pool fixes from master

[Mehdi Abaakouk (sileht)]

s/even/unless

[Alexei Kornienko (alexei-kornienko)]

Cause of this behaviour new connection is opened for each message sent. So for me it looks like a bug

[Mehdi Abaakouk (sileht)]

Yes the pool are never created in 1.3.0 and this was the desired behavior and since

https://github.com/openstack/oslo.messaging/commit/53b9d741a8f5a2fa6cbaea9e23a3679a6af235a4

It works.