fanout call() should not be allowed

Bug #1336759 reported by Mark McLoughlin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.messaging
High
Mehdi Abaakouk

Bug Description

An oddity of the oslo.messaging API is that you can do:

  cctxt = self.client.prepare(fanout=True)
  return cctxt.call(ctxt, 'foo')

This is unintentional - we should not allow fanout call(). We should probably just raise an exception in the RPC client if it is attempted.

The reason this was missed was that oslo-incubator only allowed fanout via the fanout_cast() method so there was no need to explicitly check.

Changed in oslo.messaging:
assignee: nobody → Oleksii Zamiatin (ozamiatin)
Changed in oslo.messaging:
assignee: Oleksii Zamiatin (ozamiatin) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (master)

Fix proposed to branch: master
Review: https://review.openstack.org/138684

Changed in oslo.messaging:
assignee: nobody → Mehdi Abaakouk (sileht)
status: Triaged → In Progress
Mehdi Abaakouk (sileht)
Changed in oslo.messaging:
milestone: none → next-kilo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (master)

Reviewed: https://review.openstack.org/138684
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=09cd9c0fd3413b541bfc375a4bf009ac473fcef8
Submitter: Jenkins
Branch: master

commit 09cd9c0fd3413b541bfc375a4bf009ac473fcef8
Author: Mehdi Abaakouk <email address hidden>
Date: Wed Dec 3 12:17:18 2014 +0100

    Don't allow call with fanout target

    Using call with a fanout target is an oddity.

    This change removes that.

    Closes bug: #1336759

    Change-Id: I5d7dc8a6df72b910d67bbcdddd5256b6ad6ec73a

Changed in oslo.messaging:
status: In Progress → Fix Committed
Changed in oslo.messaging:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers