rabbit connection errors return non-useful message

[Andrew Woodward]

For example rabbit connection may spam log with

2014-06-02 14:19:36.183 ERROR oslo.messaging._drivers.impl_rabbit [req-64530bd7-032c-4bd7-9098-d6926ddb7eb8 None None] AMQP server on 10.0.0.23:5672 is unreachable: Socket closed. Trying again in 1 seconds.

When in this case, the rabbit issue is that the user password is bad. We should return a more meaningful message. In this case it may also be useful to abort the caller since it will never succeed.

[Ben Nemec (bnemec)]

Agree with improving the log message, but I don't think we should abort in this case. For example, in TripleO we may be in the process of configuring the rabbitmq server when another node tries to connect to it. In that case the credentials may not work on the first call, but a subsequent call may succeed.

[Mark McLoughlin (markmc)]

Fix here: https://review.openstack.org/#/c/97353/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/107907

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/107907
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=faf2b699b340634b904cdd8590b271b4b1862bf1
Submitter: Jenkins
Branch: stable/icehouse

commit faf2b699b340634b904cdd8590b271b4b1862bf1
Author: Aaron Rosen <email address hidden>
Date: Mon Jun 2 14:37:30 2014 -0700

    Add check credentials to log message if rabbmitmq closes socket

    If one has the credentials misconfigured for rabbitmq currently the following
    error message is shown: "AMQP server on 10.0.0.23:5672 is unreachable:
    Socket closed. Trying again in 1 seconds. " This is confusing because the
    problem is the login creditentials are wrong but the server can be reached.

    Since the rabbmitmq server allowed the initial connection and closed the
    socket it's likely an authenication issue. This patch now logs: "AMQP server
    10.0.0.23:5672 closed the connection. Check login credentials: Socket closed"
    to hint the user that it could be a credential issue.

    Change-Id: Iadff35d88a9cf704c1edd2d5036a113966db3ea3
    Closes-bug: 1325750
    (cherry picked from commit bf281aace507dec7547e40f68d8cd7bb290dc903)