oslo-messaging-zmq-receiver cannot recive any messages

[zhangjialong]

In icehouse b3 and rc1,when we use impl_zmq as rpc_backend, nova cannot send any message to oslo-messaging-zmq-receiver.
The reason is in impl_zmq.py file, we use serialize_msg method with two params but it can noly recive one params.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/84618

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/84704

[Mark McLoughlin (markmc)]

Hmm, there is an issue with the code ... however, I think we may have accidentally changed the default behaviour

In Havana Nova, we would *only* have sent messages via this "envelope" code path if you were using rpc_notifier2

However, in Icehouse, it appears like we're sending using an envelope in all cases except where you're using the original notification format

See the fix for that I've just posted

[Mark McLoughlin (markmc)]

Marking as low because the zmq driver is barely maintained and untested; we shouldn't be surprised when it's broken

[zhangjialong (zhangjl)]

Well, in my view, we should thinking more about zmq because it`s faster and more powerful than rabbitmq and qpid.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/84618
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=2e3b8878c9a9b181962365c78d79d08af766e201
Submitter: Jenkins
Branch: master

commit 2e3b8878c9a9b181962365c78d79d08af766e201
Author: zhangjl <email address hidden>
Date: Wed Apr 2 12:28:14 2014 +0800

    Oslo-messaging-zmq-receiver cannot recive any messages

    In Icehouse b3 and rc1, when we use impl_zmq as
    rpc_backend in nova, nova cannot send any messages
    throught impl_zmq to oslo-messaging-zmq-receiver.
    The reason is we send two params to serialize_msg
    method but it only can recive one.To fix this
    problem, I removed the second param which not
    used when we call the method serialize_msg.

    Change-Id: I2e7546147affd9493f425fd879169932ef206d48
    Closes-bug: #1301132

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/84704
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=8aa17091b46162e9cdf5b5c63092be82708d7686
Submitter: Jenkins
Branch: master

commit 8aa17091b46162e9cdf5b5c63092be82708d7686
Author: Mark McLoughlin <email address hidden>
Date: Wed Apr 2 12:59:45 2014 +0100

    zmq: switch back to not using message envelopes

    In oslo-incubator, we default to not serializing messages using a
    message envelope:

      def _cast(.., envelope=False, ...)

    except using the v2 notifyer which explicitly passes envelope=True.

    However, in oslo.messaging, we accidentally switched to using a
    message envelope:

         def _send(self, ..., envelope=True):

    This was not intentional and may be disruptive to users.

    This issue was identified because the envelope=True path just doesn't
    work! We don't have any zmq tests in oslo.messaging, but even in
    oslo-incubator the code path isn't tested and has been broken since
    I73aad7697cf83ad4aabb3c2058b7cc4f53f783c2

    Partial-Bug: #1301132
    Change-Id: I6aa2e2ac3cebf443719d64ebcd9eaadc0a9328b8

[James Page (james-page)]

Ubuntu SRU Information

[Impact]
ZeroMQ support in 14.04 for OpenStack is currently broken; message sending fails and envelopes are inconsistently used.

[Test Case]
Configure any OpenStack project to use ZeroMQ; daemons will silently fail to send any messages

[Regression Potential]
Minimal and limited in scope to already broken ZeroMQ driver.