Notifier API does not support sending to specific exchange

[Mark McLoughlin]

See https://review.openstack.org/70106

In the notify listener tests, we do:

        def mock_notifier_exchange(name):
            def side_effect(target, ctxt, message, version):
                target.exchange = name
                return transport._driver.send_notification(target, ctxt,
                                                           message, version)
            transport._send_notification = mock.MagicMock(
                side_effect=side_effect)

This highlights that we nave no ability to send notifications on a specific exchange

Is the answer here to add an exchange parameter to the Notifier constructor?

[PeterZhang (zhangshengping2012)]

Hello, there.

we have defined the specific exchange in a Target object, do we?
and Notifier will accept this target object as a parameter.

so why we need let the Notifier to accept an exchange parameter again?

[PeterZhang (zhangshengping2012)]

my bad, I see the listener accept the target.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/390510

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ben Nemec (<email address hidden>) on branch: master
Review: https://review.openstack.org/390510
Reason: Okay, let's abandon for now then. It can always be restored if necessary.

[Ben Nemec (bnemec)]

I'm going to close this based on Ken's comments on https://review.openstack.org/#/c/390510/

"The exchange can be set indirectly via the set_transport_defaults method:

https://git.openstack.org/cgit/openstack/oslo.messaging/tree/oslo_messaging/transport.py#n71

It doesn't seem like folks are asking for anything beyond that. Unless there's a consumer for this feature I'd say abandon it."

Given the age of this bug, I'm going to close it as fixed and if someone needs more functionality they can open a new one.