stevedore 0.14 changes _load_plugins parameter list, mocking breaks

Bug #1273455 reported by Sean Dague
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Critical
Doug Hellmann
Ironic
Fix Released
Critical
aeva black
OpenStack Compute (nova)
Fix Released
Critical
Sean Dague
Grizzly
Fix Released
Critical
Sean Dague
Havana
Fix Released
Critical
Sean Dague
oslo.messaging
Fix Released
Critical
Doug Hellmann
stevedore
Fix Released
Critical
Doug Hellmann

Bug Description

In stevedore 0.14 the signature on _load_plugins changed. It now takes an extra parameter. The nova and ceilometer unit tests mocked to the old signature, which is causing breaks in the gate.

Sean Dague (sdague)
Changed in nova:
status: New → In Progress
importance: Undecided → Critical
assignee: nobody → Sean Dague (sdague)
Changed in ceilometer:
importance: Undecided → Critical
Changed in ceilometer:
assignee: nobody → Doug Hellmann (doug-hellmann)
Sean Dague (sdague)
Changed in oslo.messaging:
importance: Undecided → Critical
Changed in oslo.messaging:
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :
Revision history for this message
Joe Gordon (jogo) wrote :
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

stevedore 0.14.1 should fix ceilometer and oslo.messaging

Changed in python-stevedore:
status: New → Fix Released
assignee: nobody → Doug Hellmann (doug-hellmann)
importance: Undecided → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/69491

Changed in ceilometer:
status: New → In Progress
Changed in oslo.messaging:
assignee: Davanum Srinivas (DIMS) (dims-v) → Doug Hellmann (doug-hellmann)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (master)

Fix proposed to branch: master
Review: https://review.openstack.org/69492

Changed in oslo.messaging:
milestone: none → icehouse-3
Changed in ceilometer:
milestone: none → icehouse-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/69491
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=3257d83bbb3e2302638581c995e44d6e84ad44c0
Submitter: Jenkins
Branch: master

commit 3257d83bbb3e2302638581c995e44d6e84ad44c0
Author: Doug Hellmann <email address hidden>
Date: Mon Jan 27 17:44:44 2014 -0500

    Use stevedore's make_test_instance

    Replace the use of TestManager with make_test_instance
    to get an instance of the type of manager expected.
    The old TestManger class is deprecated.

    Change-Id: I73f3202ac7a1420aaa303d5ea2e741b2fe5673e9
    Partial-bug: #1273455

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (stable/grizzly)

Related fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/69584

Alan Pevec (apevec)
Changed in oslo.messaging:
status: In Progress → Fix Committed
status: Fix Committed → In Progress
Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
aeva black (tenbrae) wrote :

Fix proposed to Ironic, but tagged with the duplicate bug and already in our gate pipe.

Review: https://review.openstack.org/69495

Changed in ironic:
status: New → In Progress
importance: Undecided → Critical
assignee: nobody → Devananda van der Veen (devananda)
milestone: none → icehouse-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (stable/grizzly)

Reviewed: https://review.openstack.org/69584
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=fb82a457b0692bd5ce2d550f9c1b9c11fec18aed
Submitter: Jenkins
Branch: stable/grizzly

commit fb82a457b0692bd5ce2d550f9c1b9c11fec18aed
Author: Sean Dague <email address hidden>
Date: Mon Jan 27 16:35:11 2014 -0500

    support stevedore >= 0.14

    the previous mocks made some very specific assumptions about the
    behavior of an internal private method in stevedore, which changed
    in 0.14. Make the mocks more flexible so they work regardless.

    Related-Bug: #1273455

    Addapted from master & stable/havana backports

    Change-Id: I5063c652c705fd512f90ff3897a4c590f7ba7c02

tags: added: in-stable-grizzly
aeva black (tenbrae)
Changed in ironic:
status: In Progress → Fix Committed
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

The oslo.messaging fix to the tests is in https://review.openstack.org/#/c/69492/

Changed in oslo.messaging:
status: In Progress → Fix Committed
gordon chung (chungg)
Changed in ceilometer:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-3
Thierry Carrez (ttx)
Changed in ironic:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo.messaging:
status: Fix Committed → Fix Released
Alan Pevec (apevec)
tags: removed: in-stable-grizzly
Thierry Carrez (ttx)
Changed in oslo.messaging:
milestone: icehouse-3 → 1.3.0
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: icehouse-3 → 2014.1
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-3 → 2014.1
Thierry Carrez (ttx)
Changed in ironic:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.