messaging: Lack of tests for qpid driver

Bug #1255239 reported by Ben Nemec
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.messaging
High
Numan Siddique

Bug Description

So I was looking at https://review.openstack.org/#/c/57692 and decided to see how hard it would be to extend some qpid test cases to include this exception. Only there are no qpid test cases that I can find:

[fedora@openstack tests]$ pwd
/opt/stack/oslo.messaging/tests
[fedora@openstack tests]$ grep -i qpid *
[fedora@openstack tests]$

This seems like a pretty serious shortcoming to me. Somebody could accidentally merge a completely broken change and we wouldn't know until a user hit the bug.

affects: oslo → oslo.messaging
Changed in oslo.messaging:
status: New → Triaged
importance: Undecided → High
information type: Public → Public Security
information type: Public Security → Public
Changed in oslo.messaging:
assignee: nobody → Numan (numan-siddique)
Mark McLoughlin (markmc)
Changed in oslo.messaging:
milestone: none → icehouse-3
Changed in oslo.messaging:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (master)

Fix proposed to branch: master
Review: https://review.openstack.org/75638

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/75853

Changed in oslo.messaging:
milestone: icehouse-3 → icehouse-rc1
milestone: icehouse-rc1 → icehouse-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (master)

Reviewed: https://review.openstack.org/75853
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=c872f8d67045fb287850d8cdc1ba4b865c84c19c
Submitter: Jenkins
Branch: master

commit c872f8d67045fb287850d8cdc1ba4b865c84c19c
Author: Numan Siddique <email address hidden>
Date: Mon Feb 24 18:04:11 2014 +0530

    Adds unit test cases to impl_qpid

    Change-Id: I0c056efd9fb8b48d02a11dfb969ee98b736ba017
    Closes-Bug: #1255239

Changed in oslo.messaging:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in oslo.messaging:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo.messaging:
milestone: icehouse-3 → 1.3.0
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers