Config file generator cannot discover oslo.messaging config options

Bug #1241566 reported by Mark McLoughlin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo-incubator
Fix Released
High
Doug Hellmann
oslo.messaging
Fix Released
High
Mark McLoughlin

Bug Description

See e.g. https://review.openstack.org/39929

Porting Nova to oslo.messaging meant that all the messaging related config options disappeared from the sample config file

Mark McLoughlin (markmc)
Changed in oslo.messaging:
milestone: 1.3.0a1 → 1.3.0a2
Mark McLoughlin (markmc)
Changed in oslo.messaging:
milestone: 1.3.0a2 → icehouse-1
Mark McLoughlin (markmc)
Changed in oslo.messaging:
milestone: icehouse-1 → icehouse-2
Mehdi Abaakouk (sileht)
Changed in oslo.messaging:
assignee: nobody → Mehdi Abaakouk (sileht)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.messaging (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59989

Changed in oslo.messaging:
status: Triaged → In Progress
Mehdi Abaakouk (sileht)
Changed in oslo.messaging:
assignee: Mehdi Abaakouk (sileht) → nobody
status: In Progress → Confirmed
Revision history for this message
Mark McLoughlin (markmc) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to oslo.messaging (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/66029

Mark McLoughlin (markmc)
Changed in oslo.messaging:
assignee: nobody → Mark McLoughlin (markmc)
Changed in oslo:
assignee: nobody → Doug Hellmann (doug-hellmann)
importance: Undecided → High
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/66955
Committed: https://git.openstack.org/cgit/openstack/oslo-incubator/commit/?id=5dce17bcee873d931df2467d437e04c8d93fefb2
Submitter: Jenkins
Branch: master

commit 5dce17bcee873d931df2467d437e04c8d93fefb2
Author: Doug Hellmann <email address hidden>
Date: Wed Jan 15 21:51:59 2014 +0000

    Use entry points to discover options in libraries

    When generating the sample configuration file, we want to include
    options defined in libraries used by the application (especially
    oslo libraries). Add a section to the sample generator to look
    at entry points in the 'oslo.config.opts' namespace and include
    their return values in the output.

    Implements: blueprint improve-config-discovery-for-docs
    Related-Bug: #1241566

    Change-Id: I635cd8e60ca687851c9dd891667ecc2ca3e8720c

Changed in oslo:
milestone: none → icehouse-2
status: In Progress → Fix Committed
Changed in oslo.messaging:
milestone: icehouse-2 → icehouse-3
Thierry Carrez (ttx)
Changed in oslo:
status: Fix Committed → Fix Released
Revision history for this message
Mark McLoughlin (markmc) wrote :

changes to make this happen in Nova:

  oslo.messaging - https://review.openstack.org/66029
  oslo-incubator - https://review.openstack.org/69355
  nova - https://review.openstack.org/69357

Changed in oslo.messaging:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to oslo.messaging (master)

Reviewed: https://review.openstack.org/66029
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=0eb5a6f6c73b1300021dd8afef69459fa5b0f6cb
Submitter: Jenkins
Branch: master

commit 0eb5a6f6c73b1300021dd8afef69459fa5b0f6cb
Author: Mark McLoughlin <email address hidden>
Date: Fri Jan 10 17:43:02 2014 +0000

    Expose an entry point to list all config options

    Register a oslo.messaging entry point in the oslo.config.opts namespace
    which, when called, returns a list of the configuration options which
    may be registered by the library at runtime.

    The idea here is that the sample config file generator can query this
    and include the returned options in the sample config file of any
    applications which use the library.

    Some sample code for fetching available options:

      import pkg_resources

      for ep in pkg_resources.iter_entry_points('oslo.config.opts'):
          if ep.name == "oslo.messaging":
              list_opts = ep.load()
              for g, opts in list_opts():
                  opts.sort(key=lambda x: x.name)
                  print "[%s]" % g
                  for o in opts:
                      print "%s = %s" % (o.name, o.default)
                  print

    Related-Bug: #1241566
    Change-Id: Ic28351258652d2ea38974e2f4d1aa6b1d3dd7192

Mark McLoughlin (markmc)
Changed in oslo.messaging:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in oslo.messaging:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo:
milestone: icehouse-2 → 2014.1
Thierry Carrez (ttx)
Changed in oslo.messaging:
milestone: icehouse-3 → 1.3.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.