pyinotify is unmaintained and is not compatible with python 3.12

Bug #2059855 reported by Takashi Kajinami
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.log
Fix Released
High
Takashi Kajinami

Bug Description

While looking into https://bugs.launchpad.net/masakari/+bug/1740111 , I noticed that pyinotify[1] hasn't been updated for 9 years. It was discussed that inotify may be a replacement, but it hasn't been maintained for 4 years so is no longer valid.

[1] https://github.com/seb-m/pyinotify
[2] https://github.com/dsoprea/PyInotify

What is worse, pyinotify uses asyncore which has been removed from Python 3.12.

affects: masakari → oslo.log
Changed in oslo.log:
assignee: nobody → Takashi Kajinami (kajinamit)
importance: Undecided → High
Changed in oslo.log:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to oslo.log (master)

Reviewed: https://review.opendev.org/c/openstack/oslo.log/+/914788
Committed: https://opendev.org/openstack/oslo.log/commit/31603ac6dacd0b47ec9f02d99bfdd0a7b683119c
Submitter: "Zuul (22348)"
Branch: master

commit 31603ac6dacd0b47ec9f02d99bfdd0a7b683119c
Author: Takashi Kajinami <email address hidden>
Date: Sun Mar 31 00:54:59 2024 +0900

    Deprecate watch_log_file

    This feature has been broken for some time without any actual update
    to fix it. Also the pyinotify package used hasn't been updated for 9
    years and looks badly unmaintained.

    Related-Bug: #1740111
    Related-Bug: #2059855
    Change-Id: If776fee0072d95737e1c19ad673a3c881a89de06

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to oslo.log (stable/2024.1)

Related fix proposed to branch: stable/2024.1
Review: https://review.opendev.org/c/openstack/oslo.log/+/914880

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on oslo.log (stable/2024.1)

Change abandoned by "Takashi Kajinami <email address hidden>" on branch: stable/2024.1
Review: https://review.opendev.org/c/openstack/oslo.log/+/914880
Reason: https://review.opendev.org/c/openstack/oslo.log/+/915068 would be a better way forward.

description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.log (master)

Reviewed: https://review.opendev.org/c/openstack/oslo.log/+/915068
Committed: https://opendev.org/openstack/oslo.log/commit/b977cb9becbeaaa67bb663bd8db5aa6846e495b9
Submitter: "Zuul (22348)"
Branch: master

commit b977cb9becbeaaa67bb663bd8db5aa6846e495b9
Author: Takashi Kajinami <email address hidden>
Date: Thu Apr 4 23:08:05 2024 +0900

    Remove implementation for watch_log_file

    ... and raise an exception when the feature is explicitly requested.

    The feature has been broken for some time, and depends on pyinotify
    library which has been unmaintained for long time and is not compatible
    with python 3.12 (because it uses asyncore).

    Related-Bug: #1740111
    Closes-Bug: #2059855
    Change-Id: I209b1260ed4de64cbfc561a1da81a66f7a5ea397

Changed in oslo.log:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/oslo.log 6.0.0

This issue was fixed in the openstack/oslo.log 6.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.