Error when using formater JSONFormatter in Python3.5

[Suff]

In Python3.5 was added new argument for _create_formatters() function in /usr/lib/python3.5/logging/config.py. Now, before formatter was returned, logging.Formatter takes obvious style argument. (f = c(fs, dfs, stl)).
When we are using JSONFormatter, we get traceback.

Traceback (most recent call last):
  File "/usr/lib/python-exec/python3.5/nova-api", line 10, in <module>
    sys.exit(main())
  File "/usr/lib64/python3.5/site-packages/nova/cmd/api.py", line 41, in main
    logging.setup(CONF, "nova")
  File "/usr/lib64/python3.5/site-packages/oslo_log/log.py", line 262, in setup
    _load_log_config(conf.log_config_append)
  File "/usr/lib64/python3.5/site-packages/oslo_log/log.py", line 223, in _load_log_config
    disable_existing_loggers=False)
  File "/usr/lib64/python3.5/logging/config.py", line 76, in fileConfig
    formatters = _create_formatters(cp)
  File "/usr/lib64/python3.5/logging/config.py", line 125, in _create_formatters
    f = c(fmt=fs, datefmt=dfs, style=stl)
TypeError: __init__() got an unexpected keyword argument 'style'

For current working, __init__ in JSONFormatter class must takes style argument.

[Doug Hellmann (doug-hellmann)]

I think that patch looks correct. Are you set up so you can submit it via gerrit instead of as an attachment here?

[Suff (dmitry-a-grachev)]

Yes, I can try it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/534658

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/534658
Committed: https://git.openstack.org/cgit/openstack/oslo.log/commit/?id=89bbb3fb79ecfa45ed41afee86900131b3e37dc6
Submitter: Zuul
Branch: master

commit 89bbb3fb79ecfa45ed41afee86900131b3e37dc6
Author: Suff <email address hidden>
Date: Wed Jan 17 10:47:11 2018 +0300

    Fix Formatter subclasses for Python 3.2+

    Python 3.2 added the 'style' parameter to 'logging.Formatter.__init__'.
    This is provided by 'logging.config.fileConfig' meaning this currently
    raises a 'TypeError' similar to the below when the incompatible
    formatters, JSONFormatter and FluentFormatter, are used with Python 3.2
    or greater.

      TypeError: __init__() got an unexpected keyword argument 'style'

    Resolve this by simply adding the parameter to the list. There is more
    work we can do here (like actually supporting this parameter) but that's
    a job for another patch.

    Note that we can't actually test this as doing so would involve invoking
    'logging.config.fileConfig', which in turn would modify the global state
    of the 'logging' module. You can thank the singleton pattern for that.

    Change-Id: I9b339163ddfe440bc6782ced33595a0dcf60f658
    Closes-Bug: 1739743
    Co-Authored-By: Stephen Finucane <email address hidden>