Logging to /dev/log is not portable

Bug #1391428 reported by Roman Podoliaka
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
oslo.log
Fix Released
Wishlist
Julien Danjou

Bug Description

When use_syslog is set to True, we log to /dev/log. This might not work on other platforms except Linux (https://docs.python.org/2/library/logging.handlers.html#sysloghandler)

affects: pbr → oslo.log
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.log (master)

Fix proposed to branch: master
Review: https://review.openstack.org/136842

Changed in oslo.log:
assignee: nobody → Julien Danjou (jdanjou)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on oslo.log (master)

Change abandoned by Roman Podoliaka (<email address hidden>) on branch: master
Review: https://review.openstack.org/133912

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to oslo.log (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/159606

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to oslo.log (master)

Reviewed: https://review.openstack.org/159606
Committed: https://git.openstack.org/cgit/openstack/oslo.log/commit/?id=2bf8164a908b51c13d4709e63e7cb2905b5548c7
Submitter: Jenkins
Branch: master

commit 2bf8164a908b51c13d4709e63e7cb2905b5548c7
Author: John Stanford <email address hidden>
Date: Thu Feb 26 12:47:16 2015 -0800

    Make use_syslog=True log to syslog via /dev/log

    After upgrade from Icehouse to Juno OpenStack services don't log to
    syslog via /dev/log anymore. This behaviour was introduced in commit
    1188d88a73e75da5c143d0dfad34e10dad0daee0. While /dev/log is arguably
    not a very portable default, breaking the backwards compatibility is
    even worse.
    This commit restores the original behaviour. /dev/log portability
    issues will be addressed separately.
    Closes-Bug: #1385295
    Related-Bug: #1391428

    Change-Id: I5c450595fde7451a5bf9372430a53e75dd5773a3

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.log (master)

Reviewed: https://review.openstack.org/136842
Committed: https://git.openstack.org/cgit/openstack/oslo.log/commit/?id=33f5c6f94d94d5464fea38229d880f177b05aff7
Submitter: Jenkins
Branch: master

commit 33f5c6f94d94d5464fea38229d880f177b05aff7
Author: Julien Danjou <email address hidden>
Date: Mon Nov 24 18:35:36 2014 +0100

    Replace RFCSysLogHandler by a syslog() based one

    Rather than using the Python provided logging module that reimplents the
    whole syslog protocol and pointing it to /dev/log (which is not
    portable), we use the system calls from the syslog module, which are
    portable and default to the behaviour we actually want.

    Closes-Bug: 1385295
    Closes-Bug: 1391428

    Change-Id: I39a36316bd8778831b1bd5e7c5e2e12ede062a37

Changed in oslo.log:
status: In Progress → Fix Committed
Changed in oslo.log:
milestone: none → 1.4.0
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.log (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/193633

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.log (stable/kilo)

Reviewed: https://review.openstack.org/193633
Committed: https://git.openstack.org/cgit/openstack/oslo.log/commit/?id=9a6c22663b57b7f2d9071767dadf28e59075a75e
Submitter: Jenkins
Branch: stable/kilo

commit 9a6c22663b57b7f2d9071767dadf28e59075a75e
Author: Julien Danjou <email address hidden>
Date: Mon Nov 24 18:35:36 2014 +0100

    Replace RFCSysLogHandler by a syslog() based one

    Rather than using the Python provided logging module that reimplents the
    whole syslog protocol and pointing it to /dev/log (which is not
    portable), we use the system calls from the syslog module, which are
    portable and default to the behaviour we actually want.

    Closes-Bug: 1385295
    Closes-Bug: 1391428

    Partial-Bug: 1459046

    (cherry picked from commit 33f5c6f94d94d5464fea38229d880f177b05aff7)

    Conflicts:
     oslo_log/log.py
     requirements.txt

    Change-Id: I2e47c896841cbd43d1f5504f2b8b897fc432cd0b

tags: added: in-stable-kilo
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.