Inconsistent formats in eventlet.wsgi records

[MarkSeger]

The section of a DEBUG eventlet.wsgi record normally contains a field that looks like this:

[f9ebed7e-1efd-4ce7-af91-72150d032364 86628093430250 58924572785796]

and while running some code that parses the data into fields based on whitespace I just found a record containing this: [-], resulting in the fields positions of the records that follow changing. I'd suggest changing [-] to [- - -] for consistency.

If you consider [] a single field this is not a bug, but if you consider the whole record as space-separated values which I believe most people like me do, this makes parsing a more complicated and also sets a bad precedence.

[Mark Washenberger (markwash)]

Hi Mark,

I think your proposal makes a lot of sense. I would be quite annoyed if I had to reprogram an awk script for log parsing just to tell the difference between such lines.

However, Glance takes its logging implementation (and the default formatting settings) from the oslo project: https://launchpad.net/oslo.

So, I can see two approaches.

1) You could solve your problem directly by changing the configuration settings logging_default_format_string and logging_context_format_string to match better in your deployment.

2) You could apply this bug to the oslo project, with the idea of having oslo change their default format strings to match better. Relevant code lines are near here: https://github.com/openstack/oslo-incubator/blob/master/openstack/common/log.py#L113

In any case, I don't see this as being a problem we would want to fix directly in glance, but thank you for the feedback!

[Doug Hellmann (doug-hellmann)]

I think this is fixed in master and possibly earlier by 1640564dd15bda135ea37be3b76d5ae0ac28b7bc. Is this problem still showing up?

[Launchpad Janitor (janitor)]

[Expired for oslo.log because there has been no activity for 60 days.]