get_registered_limits() does not use the Enforcer cache

Bug #1964848 reported by melanie witt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.limit
Fix Released
Undecided
Unassigned

Bug Description

This was missed when the get_registered_limits() method was added after the Enforcer cache had been implemented:

https://github.com/openstack/oslo.limit/commit/bf9deb10c3af4c43f6952f0fcedb9d48dfd8340d

Since caching had been added in _get_limit() and get_registered_limits() does not call _get_limit(), it misses out on caching.

melanie witt (melwitt)
description: updated
Changed in oslo.limit:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.limit (master)

Reviewed: https://review.opendev.org/c/openstack/oslo.limit/+/828813
Committed: https://opendev.org/openstack/oslo.limit/commit/c67c9cf0df47947834b00bc2cbbd4524521bc011
Submitter: "Zuul (22348)"
Branch: master

commit c67c9cf0df47947834b00bc2cbbd4524521bc011
Author: melanie witt <email address hidden>
Date: Fri Feb 11 01:34:41 2022 +0000

    Move Enforcer caching closer to limit retrieval

    In change I22234e0bb6b3a1cecb29a6b99a3afcd02ffdbf5f added a
    get_registered_limits() interface but missed making it work with the
    Enforcer cache because caching was implemented in a higher layer,
    _get_limit() and get_registered_limits() could not make use of
    _get_limit().

    This moves the caching logic to where limits are retrieved from
    keystone, so that get_registered_limits() will use caching and any
    interfaces that might be added in the future will be able to benefit
    from using the cache.

    Closes-Bug: #1964848

    Change-Id: I28cdd4d3f4927b94acea3309b36999850cf2ee2a

Changed in oslo.limit:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/oslo.limit 1.6.0

This issue was fixed in the openstack/oslo.limit 1.6.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.