oslo.limit

Make callbacks required for enforcement

Bug #1790954 reported by Lance Bragstad on 2018-09-05

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	oslo.limit	Fix Released	Medium	Unassigned

Bug Description

Currently, the Enforcer objects can be instantiated with optional callbacks [0], although it doesn't really make sense to never supply a callback.

If the purpose of oslo.limit is to calculate usage and enforce it against a limit, the callback will always be required. We should remove this as an optional parameter.

[0] https://github.com/openstack/oslo.limit/blob/master/oslo_limit/limit.py#L56

See original description

Lance Bragstad (lbragstad) on 2018-09-05

description:

updated

Lance Bragstad (lbragstad) on 2018-09-06

summary:	- Make callbacks a required for enforcement + Make callbacks required for enforcement
Changed in oslo.limit:
status:	New → Triaged
importance:	Undecided → Medium

Vishakha Agarwal (vishakha.agarwal) on 2018-09-20

Changed in oslo.limit:
assignee:	nobody → Vishakha Agarwal (vishakha.agarwal)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-24: Fix proposed to oslo.limit (master)

Fix proposed to branch: master
Review: https://review.openstack.org/604795

Changed in oslo.limit:
status:	Triaged → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-28: Change abandoned on oslo.limit (master)

Change abandoned by Vishakha Agarwal (<email address hidden>) on branch: master
Review: https://review.openstack.org/604795
Reason: The bug is already Fixed.