mysql_enable_ndb-related deprecation warning emitted regardless of configuration

[Stephen Finucane]

In change Id5ddf1d6f47b8a572001f58ad8b9b8a7dbe4e8ac, oslo.db deprecated the '[database] mysql_enable_ndb' configuration option. Since then, various projects have been seeing warnings like the following on test runs:

  /opt/oslo_db/sqlalchemy/enginefacade.py:544: DeprecationWarning: Using the 'mysql_enable_ndb' argument is deprecated in version '12.1.0': Support for the MySQL NDB Cluster storage engine has been deprecated and will be removed in a future release.
    engine = engines.create_engine(

This is despite not setting the flag in their configuration. It would appear there's a mistake in that initial change somewhere.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/oslo.db/+/875627

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/oslo.db/+/880617

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Stephen Finucane <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/oslo.db/+/875627
Reason: This no longer applies to master. We want it stable-only, I guess

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/oslo.db/+/880617
Committed: https://opendev.org/openstack/oslo.db/commit/62aff14693373842cd7a28a737ccbbf9bbdb1218
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 62aff14693373842cd7a28a737ccbbf9bbdb1218
Author: Stephen Finucane <email address hidden>
Date: Mon Feb 27 17:23:31 2023 +0000

    Ignore unset opts when deprecated

    If an option is deprecated, there's a good chance we want to ignore it
    unless explicitly requested by the user. Start ignoring options that are
    deprecated and unset.

    Conflicts:
      oslo_db/tests/sqlalchemy/test_sqlalchemy.py

    NOTE(stephenfin): Conflicts are because we still have the autocommit
    parameter in our engine calls. This was removed in master in
    preparation for SQLAlchemy 2.0.

    Change-Id: I3008562db52a5625504b262d7148528a832246dd
    Signed-off-by: Stephen Finucane <email address hidden>
    Closes-Bug: #2008720
    (cherry picked from commit f6ba070657b3bb6b57cef3728b3e6b95f0bf08cb)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/oslo.db 12.3.2 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/oslo.db/+/875627
Committed: https://opendev.org/openstack/oslo.db/commit/f6ba070657b3bb6b57cef3728b3e6b95f0bf08cb
Submitter: "Zuul (22348)"
Branch: master

commit f6ba070657b3bb6b57cef3728b3e6b95f0bf08cb
Author: Stephen Finucane <email address hidden>
Date: Mon Feb 27 17:23:31 2023 +0000

    Ignore unset opts when deprecated

    If an option is deprecated, there's a good chance we want to ignore it
    unless explicitly requested by the user. Start ignoring options that are
    deprecated and unset.

    Change-Id: I3008562db52a5625504b262d7148528a832246dd
    Signed-off-by: Stephen Finucane <email address hidden>
    Closes-Bug: #2008720

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/oslo.db 13.1.0 release.