min_pool_size option is not used

Bug #1764786 reported by Doug Hellmann on 2018-04-17
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
oslo.db
Low
Erik Olof Gunnar Andersson

Bug Description

The min_pool_size option is documented and available in many deployment tools, but isn't actually used in oslo.db.

http://codesearch.openstack.org/?q=min_pool_size&i=nope&files=&repos=

 $ git grep min_pool_size
 oslo_db/options.py: cfg.IntOpt('min_pool_size',
 oslo_db/options.py: deprecated_opts=[cfg.DeprecatedOpt('sql_min_pool_size',
 oslo_db/options.py: cfg.DeprecatedOpt('sql_min_pool_size',
 oslo_db/sqlalchemy/enginefacade.py: 'db_retry_interval', 'min_pool_size',
 oslo_db/tests/sqlalchemy/test_options.py:sql_min_pool_size=10
 oslo_db/tests/sqlalchemy/test_options.py: self.assertEqual(10, self.conf.database.min_pool_size)
 oslo_db/tests/sqlalchemy/test_options.py:min_pool_size=10
 oslo_db/tests/sqlalchemy/test_options.py: self.assertEqual(10, self.conf.database.min_pool_size)
 oslo_db/tests/sqlalchemy/test_options.py: b'sql_min_pool_size=99\n'
 oslo_db/tests/sqlalchemy/test_options.py: self.assertEqual(99, self.conf.database.min_pool_size)

We should either make it useful or remove it.

Ben Nemec (bnemec) on 2018-04-17
Changed in oslo.db:
status: New → Confirmed
importance: Undecided → Low
Changed in oslo.db:
assignee: nobody → Erik Olof Gunnar Andersson (eandersson)
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/565090
Committed: https://git.openstack.org/cgit/openstack/oslo.db/commit/?id=eccb4ef22e9852e0080d24a747e0aeb65f004481
Submitter: Zuul
Branch: master

commit eccb4ef22e9852e0080d24a747e0aeb65f004481
Author: Erik Olof Gunnar Andersson <email address hidden>
Date: Sun Apr 29 19:17:56 2018 -0700

    Deprecate min_pool_size

    This option has for a long time done nothing in oslo.db
    and sqlalchemy does not support this convention. As such I
    recommend that we deprecate and eventually remove the option.

    Closes-bug: #1764786

    Change-Id: Ib07b7b4200b5cf3a34b8eed441e6754da7d446cf

Changed in oslo.db:
status: In Progress → Fix Released

This issue was fixed in the openstack/oslo.db 4.38.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers