oslo.db tests mock database connection

Bug #1366869 reported by Viktor Serhieiev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.db
Expired
High
Unassigned

Bug Description

A lot of tests in oslo.db uses mocks and doesn't work with the real databases.
oslo.db provides for OpenStack project different tools for work with database, so we should guarantee, that they work properly and check all these functionality with the real databases instead of mocks (which can be wrong, sometimes). For this we should use real DB connection in tests instated of mocks, where it is possible.

See also discussion at the first patch sets in patch https://review.openstack.org/#/c/116324/

Tags: tests
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

There may be some value in supporting the mock tests, but I agree we should look into adding functional testing against real databases for kilo.

Changed in oslo.db:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Mike Bayer (zzzeek) wrote :

to be fair, both mocks and real DB tests have their place. can you be more specific about where you're not confident in something being tested? it's possible that some of the mocks in oslo.db are built against behavioral contracts in SQLAlchemy, which are confirmed against real DB backends in our own (SQLAlchemy's) testing.

Changed in oslo.db:
status: Triaged → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for oslo.db because there has been no activity for 60 days.]

Changed in oslo.db:
status: Incomplete → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.