Common context module missed in Glance

[Viktor Serhieiev]

Common module glance.openstack.common.db.sqlalchemy.utils requires common context module [1] but this module missed in glance, so we get an error, when we try to use sqlalchemy.utils module. See an example at [2]

[1] https://github.com/openstack/glance/blob/master/glance/openstack/common/db/sqlalchemy/utils.py#L41
[2] http://logs.openstack.org/77/43277/19/check/gate-glance-python27/a4b3b56/console.html

[Zhi Yan Liu (lzy-dev)]

I'm a little worried on the future Oslo-db synchron for Glance.

Currently there is only one place use Oslo common context in Oslo-db [1], so it can be fixed easily and isn't a big deal, but because Glance don't use common context now, it means all the "context" object within the Oslo-db code are all be glance.context.RequestContext object instead of common context object, so I'm thinking how can we fix it if Oslo-db use particular method of common context object when we synchronize it in the future? Do you think it's a idea if we leverage Oslo common context in Glance completely instead of using private implementation (glance.context)?

[1] https://github.com/openstack/glance/blob/master/glance/openstack/common/db/sqlalchemy/utils.py#L186

[Viktor Serhieiev (vsergeyev)]

Agree, it sounds reasonable.

[Viktor Serhieiev (vsergeyev)]

See patch in Oslo - https://review.openstack.org/#/c/79653 (Remove common context usage from db model_query())

[Roman Podoliaka (rpodolyaka)]

In oslo.db we've been actually thinking about removing of the common context module. As you already pointed out, it's currently used only in one function, which hasn't been synced and reused in any of target OpenStack projects yet, so we can modify it easily. And from the oslo.db API point of view it actually makes sense to accept keyword arguments instead of a context instance.

At the same time, openstack.common.context is still useful for logging, so it might make sense for glance to use the common context module.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/93396

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/93396
Committed: https://git.openstack.org/cgit/openstack/oslo.db/commit/?id=4f58e79436a92acbdb6a738f3f8aa8200ebcc471
Submitter: Jenkins
Branch: master

commit 4f58e79436a92acbdb6a738f3f8aa8200ebcc471
Author: Victor Sergeyev <email address hidden>
Date: Tue May 13 11:54:23 2014 +0300

    Remove common context usage from db model_query()

    Currently, function model_query() from oslo.db.sqlalchemy.utils uses
    is_use_context() function in order to determine whether a normal or an
    admin user request is being processed. But usage of RequestContext is
    not unified across OpenStack projects, so there is no way for oslo.db to
    guarantee it processes project_id/deleted filters correctly here.

    To remove this ambiguity, project_id/deleted filters should be passed
    explicitly instead. At the same time, developers of OpenStack projects
    are encouraged to provide wrappers for oslo.db model_query() function,
    so that they could determine the values for project_id/deleted filters
    depending on how they use RequestContext in their project.

    Closes-bug: #1288846
    Change-Id: Iec5cbbc44cf9626f0464ab684dff1ba37e006151

[OpenStack Infra (hudson-openstack)]

Change abandoned by Victor Sergeyev (<email address hidden>) on branch: master
Review: https://review.openstack.org/79653

[Viktor Serhieiev (vsergeyev)]

Change https://review.openstack.org/#/c/106818/ fixes this bug in Glance