Inconsistency attribute and checking conditions.

Bug #1256835 reported by Ilya Pekelny
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo-incubator
Fix Released
Undecided
Ilya Pekelny

Bug Description

In https://github.com/openstack/oslo-incubator/blob/master/tests/unit/db/sqlalchemy/base.py#L146 defined an attribute "postgresql". In https://github.com/openstack/oslo-incubator/blob/master/tests/unit/db/sqlalchemy/base.py#L111 the attribute used to compile connection string by `_get_connect_string` from `common/db/sqlalchemy/test_migrations.py`. In https://github.com/openstack/oslo-incubator/blob/master/openstack/common/db/sqlalchemy/test_migrations.py#L40 `_get_connect_string ` obvious wait for "postgres" argument.

Ilya Pekelny (i159)
Changed in oslo:
assignee: nobody → Ilya Pekelny (i159)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo-incubator (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59347

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/59347
Committed: https://git.openstack.org/cgit/openstack/oslo-incubator/commit/?id=9a203e6f5d17cbb1a46778b51d7e8a026d0ae919
Submitter: Jenkins
Branch: master

commit 9a203e6f5d17cbb1a46778b51d7e8a026d0ae919
Author: Ilya Pekelny <email address hidden>
Date: Mon Dec 2 12:18:18 2013 +0200

    Use dialect rather than a particular DB API driver

    _get_connect_string() is too specific when choosing a DB API driver to be
    used. We shouldn't force users to use neither psycopg2 nor MySQLdb as this is
    not required for any actions provided by oslo.db. Specify only the dialect to
     be used and let SQLAlchemy choose one of the DB API drivers available.

    Closes-Bug: #1256835
    Change-Id: I685f9eecc77f2c1f920c83c5da653f3114a83679

Changed in oslo:
status: In Progress → Fix Committed
Changed in oslo:
milestone: none → icehouse-3
Thierry Carrez (ttx)
Changed in oslo:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.