db.utils.create_shadow_table() doesn't work if we have table with Enum column

[Boris Pavlovic]

In postgres we are not able to create two times Enum with the same name.

So If we try to make a shadow table for table we will get exception that Enum with the same name already exists.

So we should rename our Enum.
I think that shadow_prefix + original_name will be good convention.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/34643

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/35098

[David Ripton (dripton)]

The first review was abandoned and the second review doesn't seem to exist. Does anyone have an update on this? Looks pretty serious if it breaks all migrations with an Enum on postgres.

[Boris Pavlovic (boris-42)]

At this moment we don't use Enum, so it is not important at all

[Matt Riedemann (mriedem)]

Should this be handled in oslo.db now if it's not already?

[Sean Dague (sdague)]

This code isn't in nova any more, moving to oslo.db