neutron-db-manage returns SUCCESS on wrong subproject name

[Radosław Piliszek]

(neutron-server)[neutron@os-controller-1 /]$ neutron-db-manage --subproject neutron-sfc upgrade --contract
argument --subproject: Invalid String(choices=['vmware-nsx', 'networking-sfc', 'neutron-vpnaas', 'networking-l2gw', 'neutron-fwaas', 'neutron', 'neutron-dynamic-routing']) value: neutron-sfc
(neutron-server)[neutron@os-controller-1 /]$ echo $?
0

Tested Train and Victoria, possibly behaved like this since forever.

[Lajos Katona (lajos-katona)]

The 0 return code comes from here as I see:
https://opendev.org/openstack/oslo.config/src/commit/dce2afd7898d618336e1859283bcedea8336a7a2/oslo_config/cfg.py#L2960

raise SystemExit(2) or raise SystemExit('foo') should give what you expect.
I am not sure if it is intentionally not using argument for SystemExit.

[Brian Haley (brian-haley)]

Added oslo.config to see if changing this code is ok, but diagnosis seems correct.

[Brian Haley (brian-haley)]

Going to mark invalid for Neutron as it seems like an oslo.config bug.