config generator sorting has changed

Bug #1536899 reported by Steve Martinelli
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.config
Fix Released
Undecided
Ronald Bradford

Bug Description

looks like the latest (or possibly older) oslo.config release changed the way options are sorted when generated. An example can be seen here: https://review.openstack.org/#/c/269479/

the expected behaviour is the same order they appear here: https://github.com/openstack/keystone/blob/master/keystone/common/config.py

summary: - config generator sorting options alphabetically
+ config generator sorting has changed
description: updated
Changed in oslo.config:
assignee: nobody → Ronald Bradford (ronaldbradford)
Revision history for this message
Ronald Bradford (ronaldbradford) wrote :

The problem is from https://review.openstack.org/#/c/264864/

Working on a solution to ensure order is always maintained.

Changed in oslo.config:
status: New → Confirmed
Revision history for this message
Stuart McLaren (stuart-mclaren) wrote :

It would be great to have a project's auto-generated config files look as similar as possible from release to release (ie a diff shows only real changes rather than lots of "false" diffs due to reordering). It would especially help operators who are using the conf files to try to figure out what has changed from release to release in all the projects.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.config (master)

Fix proposed to branch: master
Review: https://review.openstack.org/272289

Changed in oslo.config:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.config (master)

Reviewed: https://review.openstack.org/272289
Committed: https://git.openstack.org/cgit/openstack/oslo.config/commit/?id=c3efa39d21f0340f9b6080fde64ddf1d32473fd6
Submitter: Jenkins
Branch: master

commit c3efa39d21f0340f9b6080fde64ddf1d32473fd6
Author: OpenStack Proposal Bot <email address hidden>
Date: Sat Jan 23 10:34:40 2016 +0000

    Retain correct order of defined config options

    Clean a given object of namespace/group/opt tuples of any duplicate options
    in a namespace/group while preserving the original ordering

    Closes-Bug: 1536899

    Change-Id: I1645897bc5910550b94367e9b3ff35037534a0e5

Changed in oslo.config:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/oslo.config 3.5.0

This issue was fixed in the openstack/oslo.config 3.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.