Make CONF.set_override with parameter enforce_type=True by default
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Cinder |
In Progress
|
Undecided
|
ChangBo Guo(gcb) | ||
Designate |
Fix Released
|
Medium
|
Unassigned | ||
Glance |
Invalid
|
Undecided
|
Unassigned | ||
Ironic |
Fix Released
|
Low
|
Javier Peña | ||
Karbor |
Fix Released
|
Undecided
|
Ji.Wei | ||
Magnum |
Fix Released
|
Undecided
|
Unassigned | ||
Murano |
Fix Released
|
Low
|
LiuNanke | ||
OpenStack Backup/Restore and DR (Freezer) |
Fix Committed
|
Undecided
|
Ji.Wei | ||
OpenStack Compute (nova) |
Fix Released
|
Low
|
Pallavi | ||
OpenStack Heat |
Fix Released
|
Low
|
Angus Salkeld | ||
OpenStack Identity (keystone) |
Fix Released
|
Undecided
|
LiuNanke | ||
OpenStack Shared File Systems Service (Manila) |
Fix Released
|
Low
|
NidhiMittalHada | ||
Quark: Money Reinvented |
New
|
Undecided
|
Unassigned | ||
Rally |
Fix Released
|
Low
|
LiuNanke | ||
cloudkitty |
Fix Released
|
Undecided
|
Chaozhe Chen | ||
kolla |
Expired
|
Undecided
|
Unassigned | ||
neutron |
Won't Fix
|
Undecided
|
Unassigned | ||
octavia |
Invalid
|
Low
|
Unassigned | ||
oslo.config |
Fix Released
|
Undecided
|
ChangBo Guo(gcb) | ||
oslo.messaging |
Fix Released
|
Undecided
|
javeme | ||
senlin |
Fix Released
|
Undecided
|
Ji.Wei | ||
tacker |
Fix Released
|
Undecided
|
Ji.Wei | ||
tempest |
Fix Released
|
Undecided
|
ChangBo Guo(gcb) | ||
watcher |
Fix Released
|
Medium
|
ting.wang |
Bug Description
1. Problems :
oslo_config provides method CONF.set_
By default parameter enforce_type=False, it doesn't check any type or value of override. If set enforce_type=True , will check parameter
override's type and value. In production code(running time code), oslo_config always checks config option's value.
In short, we test and run code in different ways. so there's gap: config option with wrong type or invalid value can pass tests when
parameter enforce_type = False in consuming projects. that means some invalid or wrong tests are in our code base.
[1] https:/
2. Proposal
1) Fix violations when enforce_type=True in each project.
2) Make method CONF.set_override with enforce_type=True by default in oslo_config
You can find more details and comments in https:/
3. How to find violations in your projects.
1. Run tox -e py27
2. then modify oslo.config with enforce_type=True
cd .tox/py27/
edit cfg.py with enforce_type=True
- def set_override(self, name, override, group=None, enforce_
+ def set_override(self, name, override, group=None, enforce_type=True):
3. Run tox -e py27 again, you will find violations.
The current state is that oslo.config make enforce_type as True by default and deprecate this parameter, will remove it in the future, the current work
is that remove usage of enforce_type in consuming projects. We can list the
usage of it in http://
Changed in oslo.config: | |
assignee: | nobody → ChangBo Guo(gcb) (glongwave) |
Changed in rally: | |
assignee: | nobody → LiuNanke (nanke-liu) |
Changed in keystone: | |
assignee: | nobody → LiuNanke (nanke-liu) |
Changed in keystone: | |
status: | New → In Progress |
Changed in rally: | |
status: | In Progress → New |
Changed in keystone: | |
status: | In Progress → New |
Changed in rally: | |
status: | New → Triaged |
importance: | Undecided → Low |
Changed in gnocchi: | |
status: | New → In Progress |
assignee: | nobody → LiuNanke (nanke-liu) |
Changed in oslo.messaging: | |
assignee: | nobody → javeme (javaloveme) |
status: | New → In Progress |
Changed in cloudkitty: | |
assignee: | nobody → Chaozhe Chen (chaozhe-chen) |
Changed in ceilometer: | |
assignee: | nobody → Chaozhe Chen (chaozhe-chen) |
Changed in neutron: | |
assignee: | nobody → caoyue (yue-cao) |
Changed in heat: | |
assignee: | nobody → tingwang (bx-wang) |
Changed in manila: | |
assignee: | nobody → tingwang (bx-wang) |
Changed in glance: | |
assignee: | nobody → tingwang (bx-wang) |
no longer affects: | sahara |
Changed in designate: | |
assignee: | nobody → tingwang (bx-wang) |
no longer affects: | glance |
Changed in watcher: | |
assignee: | nobody → tingwang (bx-wang) |
Changed in neutron: | |
status: | New → In Progress |
Changed in designate: | |
importance: | Undecided → Medium |
milestone: | none → mitaka-3 |
status: | New → Confirmed |
Changed in murano: | |
importance: | Undecided → Low |
milestone: | none → mitaka-2 |
assignee: | nobody → LiuNanke (nanke-liu) |
status: | New → In Progress |
summary: |
- Make CONF.set_override with paramter enforce_type=True by default + Make CONF.set_override with parameter enforce_type=True by default |
Changed in watcher: | |
importance: | Undecided → Medium |
milestone: | none → mitaka-3 |
Changed in manila: | |
assignee: | tingwang (bx-wang) → nobody |
Changed in murano: | |
milestone: | mitaka-2 → mitaka-3 |
Changed in manila: | |
assignee: | nobody → NidhiMittalHada (nidhimittal19) |
Changed in neutron: | |
assignee: | caoyue (yue-cao) → nobody |
Changed in watcher: | |
status: | New → Fix Released |
Changed in designate: | |
assignee: | tingwang (bx-wang) → nobody |
Changed in murano: | |
status: | In Progress → Fix Released |
Changed in cloudkitty: | |
status: | New → Fix Released |
Changed in heat: | |
assignee: | tingwang (bx-wang) → nobody |
Changed in neutron: | |
status: | In Progress → New |
Changed in cinder: | |
assignee: | nobody → ChangBo Guo(gcb) (glongwave) |
status: | New → In Progress |
no longer affects: | ceilometer |
no longer affects: | gnocchi |
Changed in manila: | |
milestone: | none → newton-1 |
Changed in manila: | |
importance: | Undecided → Low |
status: | New → Triaged |
Changed in heat: | |
importance: | Undecided → Low |
status: | New → Confirmed |
assignee: | nobody → Angus Salkeld (asalkeld) |
Changed in heat: | |
milestone: | none → newton-1 |
Changed in nova: | |
assignee: | nobody → Pallavi (pallavi-s) |
tags: | added: oslo testing |
Changed in nova: | |
importance: | Undecided → Low |
status: | New → In Progress |
Changed in oslo.config: | |
status: | New → In Progress |
Changed in glance: | |
assignee: | nobody → Ji.Wei (jiwei) |
description: | updated |
description: | updated |
description: | updated |
Changed in nova: | |
status: | In Progress → Fix Released |
Changed in glance-store: | |
assignee: | nobody → Ji.Wei (jiwei) |
Changed in ceilometer: | |
assignee: | nobody → Ji.Wei (jiwei) |
Changed in glance: | |
assignee: | Ji.Wei (jiwei) → nobody |
status: | New → Invalid |
Changed in tacker: | |
assignee: | nobody → Ji.Wei (jiwei) |
Changed in freezer: | |
assignee: | nobody → Ji.Wei (jiwei) |
Changed in tacker: | |
status: | New → In Progress |
Changed in gnocchi: | |
assignee: | nobody → Hanxi Liu (hanxi-liu) |
Changed in ceilometer: | |
assignee: | Ji.Wei (jiwei) → Hanxi Liu (hanxi-liu) |
status: | New → In Progress |
Changed in gnocchi: | |
status: | New → In Progress |
Changed in freezer: | |
status: | New → In Progress |
Changed in glance-store: | |
status: | New → In Progress |
Changed in panko: | |
assignee: | nobody → xiaozhuangqing (xiaozhuangqing) |
Changed in aodh: | |
assignee: | nobody → xiaozhuangqing (xiaozhuangqing) |
status: | New → In Progress |
Changed in panko: | |
status: | New → In Progress |
Changed in magnum: | |
assignee: | nobody → Ji.Wei (jiwei) |
Changed in quark: | |
assignee: | nobody → Ji.Wei (jiwei) |
Changed in senlin: | |
assignee: | nobody → Ji.Wei (jiwei) |
Changed in ironic: | |
assignee: | nobody → Ji.Wei (jiwei) |
Changed in karbor: | |
assignee: | nobody → Ji.Wei (jiwei) |
Changed in octavia: | |
assignee: | nobody → Ji.Wei (jiwei) |
Changed in kolla: | |
assignee: | nobody → Ji.Wei (jiwei) |
Changed in karbor: | |
status: | New → In Progress |
Changed in ironic: | |
importance: | Undecided → Low |
status: | New → Triaged |
Changed in karbor: | |
status: | In Progress → Fix Released |
Changed in magnum: | |
status: | New → In Progress |
no longer affects: | panko |
no longer affects: | gnocchi |
Changed in senlin: | |
status: | New → Fix Released |
Changed in octavia: | |
importance: | Undecided → Low |
no longer affects: | ceilometer |
no longer affects: | aodh |
Changed in kolla: | |
importance: | Undecided → Low |
status: | New → Confirmed |
Changed in kolla: | |
milestone: | none → ocata-3 |
no longer affects: | glance-store |
Changed in tempest: | |
status: | New → Confirmed |
description: | updated |
Changed in tacker: | |
status: | In Progress → Fix Released |
Changed in freezer: | |
status: | In Progress → Fix Committed |
Changed in quark: | |
assignee: | Ji.Wei (jiwei) → nobody |
Changed in magnum: | |
status: | In Progress → Fix Released |
assignee: | Ji.Wei (jiwei) → nobody |
Changed in kolla: | |
assignee: | Ji.Wei (jiwei) → nobody |
Changed in octavia: | |
assignee: | Ji.Wei (jiwei) → nobody |
Fix proposed to branch: master /review. openstack. org/262879
Review: https:/