Make CONF.set_override with parameter enforce_type=True by default
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Cinder |
Undecided
|
ChangBo Guo(gcb) | |||
| Designate |
Medium
|
Unassigned | |||
| Glance |
Undecided
|
Unassigned | |||
| Ironic |
Fix Released
|
Low
|
Javier Peña | ||
| Karbor |
Undecided
|
Ji.Wei | |||
| Magnum |
Fix Released
|
Undecided
|
Unassigned | ||
| Manila |
Low
|
NidhiMittalHada | |||
| Murano |
Low
|
LiuNanke | |||
| OpenStack Backup/Restore and DR (Freezer) |
Undecided
|
Ji.Wei | |||
| OpenStack Compute (nova) |
Low
|
Pallavi | |||
| OpenStack Heat |
Fix Released
|
Low
|
Angus Salkeld | ||
| OpenStack Identity (keystone) |
Undecided
|
LiuNanke | |||
| Quark: Money Reinvented |
Undecided
|
Unassigned | |||
| Rally |
Low
|
LiuNanke | |||
| cloudkitty |
Undecided
|
Chaozhe Chen | |||
| kolla |
Undecided
|
Unassigned | |||
| neutron |
Undecided
|
Unassigned | |||
| octavia |
New
|
Low
|
Unassigned | ||
| oslo.config |
Undecided
|
ChangBo Guo(gcb) | |||
| oslo.messaging |
Undecided
|
javeme | |||
| senlin |
Undecided
|
Ji.Wei | |||
| tacker |
Undecided
|
Ji.Wei | |||
| tempest |
Undecided
|
ChangBo Guo(gcb) | |||
| watcher |
Medium
|
ting.wang | |||
Bug Description
1. Problems :
oslo_config provides method CONF.set_
By default parameter enforce_type=False, it doesn't check any type or value of override. If set enforce_type=True , will check parameter
override's type and value. In production code(running time code), oslo_config always checks config option's value.
In short, we test and run code in different ways. so there's gap: config option with wrong type or invalid value can pass tests when
parameter enforce_type = False in consuming projects. that means some invalid or wrong tests are in our code base.
[1] https:/
2. Proposal
1) Fix violations when enforce_type=True in each project.
2) Make method CONF.set_override with enforce_type=True by default in oslo_config
You can find more details and comments in https:/
3. How to find violations in your projects.
1. Run tox -e py27
2. then modify oslo.config with enforce_type=True
cd .tox/py27/
edit cfg.py with enforce_type=True
- def set_override(self, name, override, group=None, enforce_
+ def set_override(self, name, override, group=None, enforce_type=True):
3. Run tox -e py27 again, you will find violations.
The current state is that oslo.config make enforce_type as True by default and deprecate this parameter, will remove it in the future, the current work
is that remove usage of enforce_type in consuming projects. We can list the
usage of it in http://
| Changed in oslo.config: | |
| assignee: | nobody → ChangBo Guo(gcb) (glongwave) |
| Changed in rally: | |
| assignee: | nobody → LiuNanke (nanke-liu) |
| Changed in rally: | |
| status: | New → In Progress |
| Changed in keystone: | |
| assignee: | nobody → LiuNanke (nanke-liu) |
| Changed in keystone: | |
| status: | New → In Progress |
Change abandoned by LiuNanke (<email address hidden>) on branch: master
Review: https:/
Fix proposed to branch: master
Review: https:/
| Changed in rally: | |
| status: | In Progress → New |
| Changed in keystone: | |
| status: | In Progress → New |
| Changed in rally: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 9ec0f3317bfb92f
Author: LiuNanke <email address hidden>
Date: Sun Jan 3 20:35:00 2016 +0800
Test: make enforce_type=True in CONF.set_override
each config option has limitation for type and value.
In production code, oslo.conf can ensure user's input
is valid, but in unit test, test methods can pass if
we use method CONF.set_override without parameter
enforce_
value to config option. This commit makes sure calling
method CONF.set_override with enforce_type=True.
Change-Id: I52fdc7ed9f74f8
Closes-bug: #1517839
| Changed in keystone: | |
| status: | New → Fix Released |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit dfd736309208d6d
Author: LiuNanke <email address hidden>
Date: Sat Jan 2 03:05:13 2016 +0800
test: make enforce_type=True in CONF.set_override
Each config option has limitation for type and value.
In production code, oslo.conf can ensure user's input
is valid, but in unit test, test methods can pass if
we use method CONF.set_override without parameter
enforce_
value to config option. This commit makes sure calling
method CONF.set_override with enforce_type=True,
Change-Id: Ib22685902103d2
Closes-Bug: #1517839
| Changed in rally: | |
| status: | Triaged → Fix Released |
| Changed in gnocchi: | |
| status: | New → In Progress |
| assignee: | nobody → LiuNanke (nanke-liu) |
Fix proposed to branch: master
Review: https:/
| Changed in oslo.messaging: | |
| assignee: | nobody → javeme (javaloveme) |
| status: | New → In Progress |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit ca6c34ac71a5060
Author: Javeme <email address hidden>
Date: Thu Jan 7 14:59:45 2016 +0800
make enforce_type=True in CONF.set_override
Each config option has limitation for type and value. If we use
method CONF.set_override without parameter enforce_type=True, we
may pass wrong type to config option.
This commit makes sure calling method CONF.set_override with
enforce_
Change-Id: I1430c93777d6e5
Closes-Bug: #1517839
| Changed in oslo.messaging: | |
| status: | In Progress → Fix Released |
| Changed in cloudkitty: | |
| assignee: | nobody → Chaozhe Chen (chaozhe-chen) |
| Changed in ceilometer: | |
| assignee: | nobody → Chaozhe Chen (chaozhe-chen) |
Related fix proposed to branch: master
Review: https:/
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit f9b52a93bb8070b
Author: Chaozhe.Chen <email address hidden>
Date: Mon Jan 11 17:48:39 2016 +0800
Test: make enforce_type=True in CONF.set_override
Method CONF.set_override to change config option's
value with designated value in unit test, but never check if the
designated vaule is valid. Each config option has a type like StrOpt,
BoolOpt, etc. StrOpt with parameter choices only allows values in set
of choices. In short, each config option has limitation for type
and value. In production code, oslo.conf can ensure user's input is
valid, but in unit test, test methods can pass if we use method
CONF.
type or wrong value to config option. This commit makes sure calling
method CONF.set_override with enforce_type=True and fixes violations.
Change-Id: Ibf5570b74947b0
Related-Bug: #1517839
| Changed in neutron: | |
| assignee: | nobody → caoyue (yue-cao) |
| Changed in heat: | |
| assignee: | nobody → tingwang (bx-wang) |
| Changed in manila: | |
| assignee: | nobody → tingwang (bx-wang) |
| Changed in glance: | |
| assignee: | nobody → tingwang (bx-wang) |
| no longer affects: | sahara |
| Changed in designate: | |
| assignee: | nobody → tingwang (bx-wang) |
| no longer affects: | glance |
| Changed in watcher: | |
| assignee: | nobody → tingwang (bx-wang) |
| Changed in neutron: | |
| status: | New → In Progress |
Related fix proposed to branch: master
Review: https:/
Related fix proposed to branch: master
Review: https:/
Related fix proposed to branch: master
Review: https:/
Related fix proposed to branch: master
Review: https:/
| Changed in designate: | |
| importance: | Undecided → Medium |
| milestone: | none → mitaka-3 |
| status: | New → Confirmed |
| Changed in murano: | |
| importance: | Undecided → Low |
| milestone: | none → mitaka-2 |
| assignee: | nobody → LiuNanke (nanke-liu) |
| status: | New → In Progress |
Change abandoned by ting wang (<email address hidden>) on branch: master
Review: https:/
Reason: Now that there's no bug here, It's OK to wait oslo.config set enforce_type to be default action.
Change abandoned by ting wang (<email address hidden>) on branch: master
Review: https:/
Reason: Now that there's no bug here, It's OK to wait oslo.config set enforce_type to be default action.
Change abandoned by ting wang (<email address hidden>) on branch: master
Review: https:/
Reason: Now that there's no bug here, It's OK to wait oslo.config set enforce_type to be default action.
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 473cee8ad3685dc
Author: ting.wang <email address hidden>
Date: Wed Jan 13 11:35:15 2016 +0800
Test: make enforce_type=True in CONF.set_override and fix error
Each config option has limitation for type and value.
We make enforce_type=True to check whether we pass wrong type.
Also fixes a type error issue in test_db_manager.py.
Change-Id: I6e111e21588525
Related-Bug: #1517839
Change abandoned by caoyue (<email address hidden>) on branch: master
Review: https:/
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit e0c1653fa83c0e3
Author: LiuNanke <email address hidden>
Date: Tue Jan 12 20:45:28 2016 +0800
make enforce_type=True in CONF.set_override
Method CONF.set_override to change config option's
value with designated value in unit test, but never check if the
designated vaule is valid. Each config option has a type like StrOpt,
BoolOpt, etc. StrOpt with parameter choices only allows values in set
of choices. In short, each config option has limitation for type
and value. In production code, oslo.conf can ensure user's input is
valid, but in unit test, test methods can pass if we use method
CONF.
type or wrong value to config option. This commit makes sure calling
method CONF.set_override with enforce_type=True and fixes violations.
Note: We can't set enforce_type=True by default in oslo.config now, it
may break all project's unit test. We can switch enforce_type=True by
default when all project fix violations like this commit.
Related-Bug: #1517839
Change-Id: Ia9f6b8a04290f9
Related fix proposed to branch: master
Review: https:/
Related fix proposed to branch: master
Review: https:/
| summary: |
- Make CONF.set_override with paramter enforce_type=True by default + Make CONF.set_override with parameter enforce_type=True by default |
| Changed in watcher: | |
| importance: | Undecided → Medium |
| milestone: | none → mitaka-3 |
Change abandoned by caoyue (<email address hidden>) on branch: master
Review: https:/
Reason: thx
| Changed in manila: | |
| assignee: | tingwang (bx-wang) → nobody |
| Changed in murano: | |
| milestone: | mitaka-2 → mitaka-3 |
| Changed in manila: | |
| assignee: | nobody → NidhiMittalHada (nidhimittal19) |
| Changed in neutron: | |
| assignee: | caoyue (yue-cao) → nobody |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 709c842502875e3
Author: caoyue <email address hidden>
Date: Sat Jan 16 15:43:11 2016 +0800
test: make enforce_type=True in CONF.set_override
each config option has limitation for type and value. In production
code, oslo.conf can ensure user's input is valid, but in unit test,
test methods can pass if we use method CONF.set_override without
parameter enforce_type=True even we pass wrong type or wrong value
to config option. This commit makes sure calling method
CONF.
Change-Id: Ia1511c1e1db53c
Related-Bug: #1517839
| Changed in watcher: | |
| status: | New → Fix Released |
This issue was fixed in the openstack/
| Changed in designate: | |
| assignee: | tingwang (bx-wang) → nobody |
| Changed in murano: | |
| status: | In Progress → Fix Released |
| Changed in cloudkitty: | |
| status: | New → Fix Released |
| Changed in heat: | |
| assignee: | tingwang (bx-wang) → nobody |
| Changed in neutron: | |
| status: | In Progress → New |
| Changed in cinder: | |
| assignee: | nobody → ChangBo Guo(gcb) (glongwave) |
| status: | New → In Progress |
| Ihar Hrachyshka (ihar-hrachyshka) wrote : | #25 |
Neutron does not need anything to do with it. We'll just wait for oslo.config to enforce the types for us.
| Changed in neutron: | |
| status: | New → Won't Fix |
| no longer affects: | ceilometer |
| no longer affects: | gnocchi |
| Changed in manila: | |
| milestone: | none → newton-1 |
| Changed in manila: | |
| importance: | Undecided → Low |
| status: | New → Triaged |
| Graham Hayes (grahamhayes) wrote : | #26 |
| Changed in designate: | |
| status: | Confirmed → Fix Released |
| Changed in heat: | |
| importance: | Undecided → Low |
| status: | New → Confirmed |
| assignee: | nobody → Angus Salkeld (asalkeld) |
Fix proposed to branch: master
Review: https:/
| Changed in heat: | |
| status: | Confirmed → In Progress |
| Changed in heat: | |
| milestone: | none → newton-1 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 3ed5948b1c20a00
Author: Angus Salkeld <email address hidden>
Date: Mon Apr 11 10:52:22 2016 +1000
Set enforce_type=True on config overrides in tests
This makes sure that type checking is done by oslo.config
on the test override values.
Change-Id: Ia8c1cb55fe98e9
Closes-bug: #1517839
| Changed in heat: | |
| status: | In Progress → Fix Released |
| NidhiMittalHada (nidhimittal19) wrote : | #29 |
working on this
| Changed in manila: | |
| status: | Triaged → In Progress |
Fix proposed to branch: master
Review: https:/
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit c8ff80353173d87
Author: nidhimittalhada <email address hidden>
Date: Thu Apr 28 14:58:18 2016 +0530
Test: make enforce_type=True in CONF.set_override
Each config option has limitation for type and value. If we use
method CONF.set_override without parameter enforce_type=True, we
may pass wrong type to config option.
This commit makes sure calling method CONF.set_override with
enforce_
Change-Id: I700dcd21941c63
Closes-Bug: #1517839
| Changed in manila: | |
| status: | In Progress → Fix Released |
This issue was fixed in the openstack/heat 7.0.0.0b1 development milestone.
This issue was fixed in the openstack/manila 3.0.0.0b1 development milestone.
Related fix proposed to branch: master
Review: https:/
Related fix proposed to branch: master
Review: https:/
Related fix proposed to branch: master
Review: https:/
| Changed in nova: | |
| assignee: | nobody → Pallavi (pallavi-s) |
| tags: | added: oslo testing |
Related fix proposed to branch: master
Review: https:/
| Changed in nova: | |
| importance: | Undecided → Low |
| status: | New → In Progress |
Related fix proposed to branch: master
Review: https:/
Related fix proposed to branch: master
Review: https:/
Related fix proposed to branch: master
Review: https:/
| Changed in oslo.config: | |
| status: | New → In Progress |
| Changed in glance: | |
| assignee: | nobody → Ji.Wei (jiwei) |
| description: | updated |
| description: | updated |
| description: | updated |
| Changed in nova: | |
| status: | In Progress → Fix Released |
| Changed in glance-store: | |
| assignee: | nobody → Ji.Wei (jiwei) |
| Changed in ceilometer: | |
| assignee: | nobody → Ji.Wei (jiwei) |
| Changed in glance: | |
| assignee: | Ji.Wei (jiwei) → nobody |
| status: | New → Invalid |
| Changed in tacker: | |
| assignee: | nobody → Ji.Wei (jiwei) |
| Changed in freezer: | |
| assignee: | nobody → Ji.Wei (jiwei) |
| Changed in tacker: | |
| status: | New → In Progress |
| Changed in gnocchi: | |
| assignee: | nobody → Hanxi Liu (hanxi-liu) |
| Changed in ceilometer: | |
| assignee: | Ji.Wei (jiwei) → Hanxi Liu (hanxi-liu) |
| status: | New → In Progress |
| Changed in gnocchi: | |
| status: | New → In Progress |
| Changed in freezer: | |
| status: | New → In Progress |
| Changed in glance-store: | |
| status: | New → In Progress |
| Changed in panko: | |
| assignee: | nobody → xiaozhuangqing (xiaozhuangqing) |
| Changed in aodh: | |
| assignee: | nobody → xiaozhuangqing (xiaozhuangqing) |
| status: | New → In Progress |
| Changed in panko: | |
| status: | New → In Progress |
| Changed in magnum: | |
| assignee: | nobody → Ji.Wei (jiwei) |
| Changed in quark: | |
| assignee: | nobody → Ji.Wei (jiwei) |
| Changed in senlin: | |
| assignee: | nobody → Ji.Wei (jiwei) |
| Changed in ironic: | |
| assignee: | nobody → Ji.Wei (jiwei) |
| Changed in karbor: | |
| assignee: | nobody → Ji.Wei (jiwei) |
| Changed in octavia: | |
| assignee: | nobody → Ji.Wei (jiwei) |
| Changed in kolla: | |
| assignee: | nobody → Ji.Wei (jiwei) |
| Changed in karbor: | |
| status: | New → In Progress |
| Changed in ironic: | |
| importance: | Undecided → Low |
| status: | New → Triaged |
| Changed in karbor: | |
| status: | In Progress → Fix Released |
| Changed in magnum: | |
| status: | New → In Progress |
| no longer affects: | panko |
| no longer affects: | gnocchi |
| Changed in senlin: | |
| status: | New → Fix Released |
| Changed in octavia: | |
| importance: | Undecided → Low |
| no longer affects: | ceilometer |
| no longer affects: | aodh |
| Changed in kolla: | |
| importance: | Undecided → Low |
| status: | New → Confirmed |
|
42 comments hidden
Loading more comments
|
view all 122 comments |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit c23c44a7b78630f
Author: ChangBo Guo(gcb) <email address hidden>
Date: Tue Jun 28 17:10:46 2016 +0800
test: fix wrong usage of config option in test_window
Developers usually use method CONF.set_override to change
config option's value in tests. By default the parameter
enforce_
override. If set enforce_type=True , will check parameter
verride type and value. In production code, oslo_config
always checks config option's value. In short, we test and
run code in different ways. For more details when we set method
set_override with parameter enforce_type=True, please see:
http://
Related-Bug: 1517839
Change-Id: I0e1929f7e6afa9
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit c7df051e3e40fa5
Author: ChangBo Guo(gcb) <email address hidden>
Date: Sat Dec 3 18:19:16 2016 +0800
Remove invalid tests for config option osapi_compute_
Config option osapi_compute_
means any value < 1 will raise ValueError in runtime. Method
set_override of ConfigOpts will not check value when enforce_type=False,
In the future release of oslo.config, will set parameter enforce_type
with True by default.
This commit fixes warning as follow:
Deprecation
value to True and then will be removed completely, please fix the
invalid Integer(min=1) value '0' for option 'osapi_
version '4.0'
Related-Bug: 1517839
Change-Id: I7da19419ed13e5
| Changed in kolla: | |
| milestone: | none → ocata-3 |
| no longer affects: | glance-store |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 3a8ba0f8ea5a691
Author: ChangBo Guo(gcb) <email address hidden>
Date: Sun Jun 12 13:18:05 2016 +0800
Make set_override/
Consuming projects usually don't set enforce_type=True by default,
and that will lead some invalid tests which don't honour Config options'
type and value limits. We began to warn user about the change since Sep,
2016 in I438aeb766d663d
notify consuming project to write correct test cases with config
options.
This commit also fixes violations in oslo.config test:
config option 'namespace' is MultiStrOpt, need pass list
to conf.set_default().
Closes-Bug: #1517839
Change-Id: Ifa552de0a994e4
| Changed in oslo.config: | |
| status: | In Progress → Fix Released |
Related fix proposed to branch: master
Review: https:/
| Luigi Toscano (ltoscano) wrote : | #87 |
You missed Tempest. Excerpt from RDO trunk logs (which uses the master branch of oslo.config, not the released version like - iirc - tox):
https:/
DEBUG: FAIL: tempest.
DEBUG: tags: worker-7
DEBUG: -------
DEBUG: Empty attachments:
DEBUG: stderr
DEBUG: stdout
DEBUG: Traceback (most recent call last):
DEBUG: File "tempest/
DEBUG: self.useFixture
DEBUG: File "/usr/lib/
DEBUG: reraise(*exc_info)
DEBUG: File "/usr/lib/
DEBUG: fixture.setUp()
DEBUG: File "tempest/
DEBUG: self.conf.
DEBUG: File "/usr/lib/
DEBUG: return f(*args, **kwargs)
DEBUG: File "/usr/lib/
DEBUG: result = f(self, *args, **kwargs)
DEBUG: File "/usr/lib/
DEBUG: opt_info['opt'], default, enforce_type)
DEBUG: File "/usr/lib/
DEBUG: converted = self._convert_
DEBUG: File "/usr/lib/
DEBUG: return opt.type(value)
DEBUG: File "/usr/lib/
DEBUG: repr(value)))
DEBUG: ValueError: Valid values are [public, admin, internal, publicURL, adminURL, internalURL], but found 'fake_v3_uri'
DEBUG: =======
DEBUG: FAIL: tempest.
DEBUG: tags: worker-7
DEBUG: -------
DEBUG: Empty attachments:
DEBUG: stderr
DEBUG: stdout
DEBUG: Traceback (most recent call last):
DEBUG: File "tempest/
DEBUG: self.useFixture
DEBUG: File "/usr/lib/
DEBUG: reraise(*exc_info)
DEBUG: File "/usr/lib/
DEBUG: fixture.setUp()
DEBUG: File "tempest/
DEBUG: self.conf.
DEBUG: File "/usr/lib/
DEBUG: return f(*args, **kwargs)
DEBUG: File "/usr/lib/
DEBUG: result = f(self, *arg...
| Changed in tempest: | |
| status: | New → Confirmed |
Fix proposed to branch: master
Review: https:/
| Changed in tempest: | |
| assignee: | nobody → ChangBo Guo(gcb) (glongwave) |
| status: | Confirmed → In Progress |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 8cc2cba2a0a278a
Author: ChangBo Guo(gcb) <email address hidden>
Date: Thu Apr 13 12:34:04 2017 +0800
Fix invalid values when setting config options' default value
Config options v3_endpoint_type, v2_public_
v2_
oslo.config 4.0 will check overridden value type by default[2],
so need remove invalid overridden values.
[1] https:/
[2] https:/
Closes-Bug: #1517839
Change-Id: I86cc9e53b86a69
| Changed in tempest: | |
| status: | In Progress → Fix Released |
Related fix proposed to branch: master
Review: https:/
Related fix proposed to branch: master
Review: https:/
Related fix proposed to branch: master
Review: https:/
Fix proposed to branch: master
Review: https:/
| Changed in ironic: | |
| assignee: | Ji.Wei (jiwei) → Javier Peña (jpena-c) |
| status: | Triaged → In Progress |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 213f7120c483a37
Author: ChangBo Guo(gcb) <email address hidden>
Date: Mon Apr 17 16:51:02 2017 +0800
Remove usage of parameter enforce_type
Oslo.config deprecated parameter enforce_type and change its
default value to True in Ifa552de0a994e4
Nova peridic py35 job failure due to the DeprecationWarning: "Using the
'enforce_type' argument is deprecated in version '4.0' and will be
removed in version '5.0': The argument enforce_type has changed its
default value to True and then will be removed completely."[1]
So need clean up usage of enforce_type.
Note this patch also change enforce_type from False to default value
True in test__get_
as runtime, we can use float type to test when config option
serial_
[1] http://
Related--Bug: #1517839
Change-Id: I94915a5c6abbbb
This issue was fixed in the openstack/tempest 16.0.0 release.
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 520c9e8b00b55e7
Author: Michael Johnson <email address hidden>
Date: Mon Apr 17 13:41:41 2017 -0700
Fix some configuration type issues.
This patch corrects some testing issues with improper configuration types.
These changes prepare octavia for oslo.config version 4.0.0 which sets
enforce_
Change-Id: I0a3bca495a40cd
Related-Bug: #1517839
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit f64154482f4a146
Author: Javier Pena <email address hidden>
Date: Tue Apr 18 14:10:22 2017 +0200
Fix unit tests for oslo.config 4.0
oslo.config 4.0 will check overridden value type by default[1],
which exposes a couple issues in Ironic:
- default_
StrOpt.
- test_get_
option url, which fails when checked by oslo.config.
[1] https:/
Change-Id: Id166da73a41c8c
Closes-Bug: #1517839
| Changed in ironic: | |
| status: | In Progress → Fix Released |
This issue was fixed in the openstack/
Related fix proposed to branch: master
Review: https:/
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit d1020785dc54a99
Author: ChangBo Guo(gcb) <email address hidden>
Date: Sun Apr 16 14:09:02 2017 +0800
Fix tests when CONF.set_override with enforce_type=True
Oslo.config make CONF.set_override with enforce_type=True by default
in Ifa552de0a994e4
I5b62427495
tests[1], this commit fixes failures:
* Method config will raise ValueError in oslo.config 4.0 , so add it
in expected exception list,
* Oslo.config ensures option 'location_strategy' only allow two values,
so remove invalid test.
Related-Bug: #1517839
Change-Id: I366042c7a739e7
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 716c70c315c3344
Author: Lance Bragstad <email address hidden>
Date: Mon Apr 10 17:04:13 2017 +0000
Remove usage of enforce_type
The usage of `enforce_type` from oslo.config will be removed in the
4.0 release of oslo.config. The default behavior has been
incorporated into set_override/
Ifa552de0
We no longer need to specify `enforce_type=True` and we should
remove it since it will be removed from oslo.config.
This commit also fixes violations with enforce_type=True.
Change-Id: I8222e84583aaa4
Related-Bug: 1517839
Related fix proposed to branch: master
Review: https:/
Related fix proposed to branch: master
Review: https:/
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit e1155a0a46ff188
Author: ChangBo Guo(gcb) <email address hidden>
Date: Fri Apr 28 23:36:03 2017 +0800
Remove test_unsupporte
Config option 'default_store' in group 'glance_store' only allows value
in [file, filesystem, http, https, swift, swift+http, swift+https,
swift+config, rbd, sheepdog, cinder, vsphere] due to the parameter
choices, oslo.config will ensure that, other value will lead ValueError.
So don't need test this case.
Related-Bug: #1517839
Change-Id: I3459a8e9f07ed9
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 5da589a8f68a0ed
Author: ChangBo Guo(gcb) <email address hidden>
Date: Fri Apr 28 16:22:10 2017 +0800
Remove test_metadata_
oslo.config will ensure option [saml]/
choices only allow values in ('technical', 'support', 'administrative',
'billing', 'other') in runtime, so don't need test in KeyStone.
This commit also remove check code for the option.
Partial-Bug: #1686921
Related-Bug: #1517839
Change-Id: I0c78a25a353d04
Related fix proposed to branch: master
Review: https:/
Related fix proposed to branch: master
Review: https:/
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 815293738ae1931
Author: ChangBo Guo(gcb) <email address hidden>
Date: Fri Apr 28 23:49:43 2017 +0800
Fix wrong overridden value of config option client_
Config option only allows the value zero which implies wait forever,
or positive integer, so we need pass positive integer. CONF.set_default
will check the value by converting it to integer, 0.1 will be converted
to 0. that leads test failure, use 1 instead.
Related-Bug: #1517839
Change-Id: I86eeff90e464fa
Related fix proposed to branch: master
Review: https:/
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit f86d53da9fa230c
Author: ChangBo Guo(gcb) <email address hidden>
Date: Fri May 5 17:02:30 2017 +0800
Remove usage of parameter enforce_type
Oslo.config deprecated parameter enforce_type and change its
default value to True in Ifa552de0a994e4
Remove the usage of it to avoid DeprecationWarning: "Using the
'enforce_type' argument is deprecated in version '4.0' and will be
removed in version '5.0': The argument enforce_type has changed its
default value to True and then will be removed completely."
Related--Bug: #1517839
Change-Id: Ie3267df7e086e0
Related fix proposed to branch: master
Review: https:/
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 381a84a4e8e3a57
Author: ChangBo Guo(gcb) <email address hidden>
Date: Mon May 8 17:55:32 2017 +0800
Remove usage of parameter enforce_type
Oslo.config deprecated parameter enforce_type and change its default
value to True in Ifa552de0a994e4
the usage of it to avoid DeprecationWarning: "Using the 'enforce_type'
argument is deprecated in version '4.0' and will be removed in version
'5.0': The argument enforce_type has changed its default value to True
and then will be removed completely."
Change-Id: I91b0f0a52b5ce8
Related--Bug: #1517839
Related fix proposed to branch: master
Review: https:/
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 3815f8ddfeb0357
Author: ChangBo Guo(gcb) <email address hidden>
Date: Mon May 22 22:43:45 2017 +0800
Remove usage of parameter enforce_type
Oslo.config deprecated parameter enforce_type and change its
default value to True in Ifa552de0a994e4
Remove the usage of it to avoid DeprecationWarning: "Using the
'enforce_type' argument is deprecated in version '4.0' and will be
removed in version '5.0': The argument enforce_type has changed its
default value to True and then will be removed completely."
Related--Bug: #1517839
Change-Id: Id45669d982d1a0
| description: | updated |
Related fix proposed to branch: master
Review: https:/
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 12b9c1dd77895c0
Author: ChangBo Guo(gcb) <email address hidden>
Date: Wed May 31 15:15:19 2017 +0800
Remove usage of parameter enforce_type
Oslo.config deprecated parameter enforce_type and change its default
value to True in Ifa552de0a994e4
usage of it to avoid DeprecationWarning: "Using the 'enforce_type'
argument is deprecated in version '4.0' and will be removed in version
'5.0': The argument enforce_type has changed its default value to True
and then will be removed completely."
Related--Bug: #1517839
Change-Id: I643e23f358e6a7
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit e78ab76fa16910b
Author: ChangBo Guo(gcb) <email address hidden>
Date: Thu May 4 13:17:46 2017 +0800
Remove usage of parameter enforce_type
Oslo.config deprecated parameter enforce_type and change its
default value to True in Ifa552de0a994e4
Remove the usage of it to avoid DeprecationWarning: "Using the
'enforce_type' argument is deprecated in version '4.0' and will be
removed in version '5.0': The argument enforce_type has changed its
default value to True and then will be removed completely."
Change-Id: If045d76574823f
Related--Bug: #1517839
Related fix proposed to branch: master
Review: https:/
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 4c972289008509e
Author: ChangBo Guo(gcb) <email address hidden>
Date: Wed Jun 14 13:23:32 2017 +0800
Remove usage of parameter enforce_type
Oslo.config deprecated parameter enforce_type and change its
default value to True in Ifa552de0a994e4
Remove the usage of it to avoid DeprecationWarning: "Using the
'enforce_type' argument is deprecated in version '4.0' and will be
removed in version '5.0': The argument enforce_type has changed its
default value to True and then will be removed completely."
Related--Bug: #1517839
Change-Id: If045d76574823f
This issue was fixed in the openstack/ironic 9.0.0 release.
Change abandoned by JiWei (<email address hidden>) on branch: master
Review: https:/
| Changed in tacker: | |
| status: | In Progress → Fix Released |
| Changed in freezer: | |
| status: | In Progress → Fix Committed |
| Changed in quark: | |
| assignee: | Ji.Wei (jiwei) → nobody |
| Changed in magnum: | |
| status: | In Progress → Fix Released |
| assignee: | Ji.Wei (jiwei) → nobody |
| Changed in kolla: | |
| assignee: | Ji.Wei (jiwei) → nobody |
| Changed in octavia: | |
| assignee: | Ji.Wei (jiwei) → nobody |
This is an automated cleanup. This bug report has been closed because it
is older than 18 months and there is no open code change to fix this.
After this time it is unlikely that the circumstances which lead to
the observed issue can be reproduced.
If you can reproduce the bug, please:
* reopen the bug report (set to status "New")
* AND add the detailed steps to reproduce the issue (if applicable)
* AND leave a comment "CONFIRMED FOR: <RELEASE_NAME>"
Only still supported release names are valid (OCATA, PIKE, QUEENS, ROCKY, ROCKY).
Valid example: CONFIRMED FOR: OCATA
| Changed in kolla: | |
| importance: | Low → Undecided |
| status: | Confirmed → Expired |
Fix proposed to branch: master
Review: https:/