option reads comments after value

[Steve Martinelli]

It seems like oslo.config will read anything specified after the = sign.

For instance:

  notification_driver = log # write to log

will not work, it had to explicitly be:

  notification_driver = log

Obviously we shouldn't allow for everything to be allowed, but I think a hashmark should be fine, since that is what it used for comments in the config files.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/199969

[OpenStack Infra (hudson-openstack)]

Change abandoned by Juan Antonio Osorio Robles (<email address hidden>) on branch: master
Review: https://review.openstack.org/199969

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/230411

[Alexis Lee (alexisl)]

"Configuration files may include comments, prefixed by specific characters (# and ;). Comments may appear on their own in an otherwise empty line, or may be entered in lines holding values or section names. In the latter case, they need to be preceded by a whitespace character to be recognized as a comment. (For backwards compatibility, only ; starts an inline comment, while # does not.)"

TL;DR: use a semicolon not a hash.

Can we close this?

[OpenStack Infra (hudson-openstack)]

Change abandoned by Tom Cammann (<email address hidden>) on branch: master
Review: https://review.openstack.org/230411
Reason: Likely to cause backwards incompatibility issues.

[Steve Martinelli (stevemar)]

i'm okay with closing this as invalid, it was a very minor issue, but if there's no easy fix, then i'm okay with that.