oslo-config-generator omits entire sections

Bug #1398979 reported by Dolph Mathews
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.config
Expired
Undecided
Unassigned

Bug Description

While keystone's [DEFAULT] section appears to be included, others such as [token] and [trust] are missing.

This issue is present in oslo.config master, but does not appear to be an issue in oslo.config 1.5.0.

To illustrate, this diff shows the effect of switching from the bash-based config generator to the python-based oslo-config-generator in oslo.config 1.5.0 (note that [token] correctly appears on both sides of the diff, so there's no issue apparent):

  https://review.openstack.org/#/c/138508/4/etc/keystone.conf.sample

This diff shows the effect of switching from the bash-based config generator in oslo.config 1.5.0 to the python-based oslo-config-generator in oslo.config master (plus https://review.openstack.org/#/c/136482/1/ -- because that's how I stumbled into this behavior):

  https://review.openstack.org/#/c/138508/3/etc/keystone.conf.sample

Note that [token] is completely missing on the right side of the diff.

And to make sure this wasn't the fault of the patch above, this shows the result of the python-based oslo-config-generator in oslo.config master (no patches applied):

  http://pasteraw.com/bx45k7t8d1a0l2t53q9rysrbf946jbr

Revision history for this message
Dolph Mathews (dolph) wrote :

Just discovered that the current master *is* 1.5.0, so there must be something else at play here.

Changed in oslo.config:
status: New → Incomplete
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

Can you include the command used to run the new config generator?

Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

It looks like keystone/common/config.py defines all of the sections and options, so I can't imagine why they aren't included in the output, and I can't reproduce that:

 $ tox -e pep8 -r --notest
 pep8 recreate: /home/dhellmann/repos/openstack/keystone/.tox/pep8
 pep8 installdeps: -r/home/dhellmann/repos/openstack/keystone/requirements.txt, - r/home/dhellmann/repos/openstack/keystone/test-requirements.txt
 pep8 develop-inst: /home/dhellmann/repos/openstack/keystone
 __________________________________________________ summary ___________________________________________________
   pep8: skipped tests
   congratulations :)
 (keystone)apu:keystone (git:master:96b1326)$ .tox/pep8/bin/oslo-config-generator --namespace keystone > sample.conf
 (keystone)apu:keystone (git:master:96b1326)$ grep '^\[' sample.conf
 [DEFAULT]
 [assignment]
 [auth]
 [cache]
 [catalog]
 [credential]
 [endpoint_filter]
 [endpoint_policy]
 [federation]
 [identity]
 [identity_mapping]
 [kvs]
 [ldap]
 [memcache]
 [oauth1]
 [os_inherit]
 [paste_deploy]
 [policy]
 [revoke]
 [saml]
 [signing]
 [ssl]
 [token]
 [trust]

Revision history for this message
Dolph Mathews (dolph) wrote :

This is what I'm running with and without tox:

  https://review.openstack.org/#/c/113905/10/tox.ini

I'll try your command instead.

Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for oslo.config because there has been no activity for 60 days.]

Changed in oslo.config:
status: Incomplete → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.