script tools/config/generate_sample.sh not working with error: Error in option "pecan_debug"

Bug #1373360 reported by Vadim Rovachev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Medium
Dina Belova
oslo-incubator
Won't Fix
Undecided
Unassigned
oslo.config
Won't Fix
Medium
Davanum Srinivas (DIMS)

Bug Description

Currently config generator will fail for the ceilometer due to the fact we're using global debug option value interpolation. Generator does not understand that type of this interpolated value is Bool and raises the error.

If added 'set -x' to script, then output is:
http://paste.openstack.org/show/114918/

If added 'raise' to 305 line in ceilometer/openstack/common/config/generator.py and run:
---------------------------------
python -m ceilometer.openstack.common.config.generator -m keystoneclient.middleware.auth_token -l oslo.messaging ceilometer/alarm/notifier/rest.py ceilometer/alarm/rpc.py ceilometer/alarm/service.py ceilometer/api/app.py ceilometer/api/controllers/v2.py ceilometer/api/__init__.py ceilometer/central/manager.py ceilometer/cli.py ceilometer/cmd/alarm.py ceilometer/collector.py ceilometer/compute/discovery.py ceilometer/compute/notifications/__init__.py ceilometer/compute/util.py ceilometer/compute/virt/inspector.py ceilometer/compute/virt/libvirt/inspector.py ceilometer/compute/virt/vmware/inspector.py ceilometer/compute/virt/xenapi/inspector.py ceilometer/coordination.py ceilometer/data_processing/notifications.py ceilometer/dispatcher/file.py ceilometer/dispatcher/__init__.py ceilometer/energy/kwapi.py ceilometer/event/converter.py ceilometer/hardware/discovery.py ceilometer/identity/notifications.py ceilometer/image/glance.py ceilometer/image/notifications.py ceilometer/ipmi/notifications/ironic.py ceilometer/ipmi/platform/intel_node_manager.py ceilometer/middleware.py ceilometer/network/notifications.py ceilometer/neutron_client.py ceilometer/notification.py ceilometer/nova_client.py ceilometer/objectstore/swift.py ceilometer/openstack/common/eventlet_backdoor.py ceilometer/openstack/common/lockutils.py ceilometer/openstack/common/log.py ceilometer/openstack/common/policy.py ceilometer/orchestration/notifications.py ceilometer/pipeline.py ceilometer/profiler/notifications.py ceilometer/publisher/messaging.py ceilometer/publisher/utils.py ceilometer/sample.py ceilometer/service.py ceilometer/storage/__init__.py ceilometer/utils.py ceilometer/volume/notifications.py
---------------------------------
then outus is:
http://paste.openstack.org/show/114924/

This bug reproduced, because in https://github.com/openstack/ceilometer/blob/1ac00d4a705d0a0adc761d7f9559c69bf3748f07/ceilometer/api/app.py#L45
default parameter is not boot variable.

Dina Belova (dbelova)
Changed in ceilometer:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Dina Belova (dbelova)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/123705

Changed in ceilometer:
status: Confirmed → In Progress
Dina Belova (dbelova)
no longer affects: oslo-incubator
description: updated
Dina Belova (dbelova)
Changed in ceilometer:
milestone: none → juno-rc1
affects: oslo.config → oslo-incubator
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to oslo.config (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/123914

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/123705
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=f92ddd636d5d764949202d376597cb85c399d467
Submitter: Jenkins
Branch: master

commit f92ddd636d5d764949202d376597cb85c399d467
Author: Dina Belova <email address hidden>
Date: Wed Sep 24 15:26:24 2014 +0400

    Fix bug with wrong bool opt value interpolation

    Other way of global debug opt value interpolation is needed
    for the pecan_debug option, as bool opt interpolation
    seems to be not working in the oslo.config

    Closes-Bug: 1373360
    Change-Id: I77c4d02b0821b559d7de7329acf11c6d490f51b1

Changed in ceilometer:
status: In Progress → Fix Committed
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :

The bug shows up in oslo-incubator version of generator.py, at the moment we are so close to juno and this fix can go only in stable/juno branch. However, the ceilometer team has a work around and no one else needs it. So marking this as invalid in oslo-incubator unless someone else hollers.

Related note, oslo.config's copy of generator.py is *very* lenient and has to be tightened up to validate the default values properly AND as a consequence the template string has to be handled as well. I'll be doing this in:
https://review.openstack.org/123914

Changed in oslo.config:
importance: Undecided → Medium
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
status: New → Confirmed
Changed in oslo-incubator:
status: New → Invalid
status: Invalid → Won't Fix
Changed in oslo.config:
status: Confirmed → In Progress
milestone: none → next-kilo
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: juno-rc1 → 2014.2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on oslo.config (master)

Change abandoned by Davanum Srinivas (dims) (<email address hidden>) on branch: master
Review: https://review.openstack.org/123914

Changed in oslo.config:
milestone: 1.5.0 → next-kilo
Changed in oslo.config:
milestone: 1.6.0 → kilo-next
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

Is this still a problem with the latest config generator code in oslo.config?

Changed in oslo.config:
status: In Progress → Incomplete
milestone: kilo-next → none
Revision history for this message
Ben Nemec (bnemec) wrote :

This was reported years ago against the incubator version of the generator, and there's no report I can see that says it still exists in oslo.config. I'm going to close this, but feel free to reopen if this is still happening.

Changed in oslo.config:
status: Incomplete → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.