tempest.conf.sample generator causes the dup entities in same group

Bug #1282887 reported by Zhikun Liu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.config
Invalid
Medium
Jon Grimm
tempest
Fix Released
Undecided
Jon Grimm

Bug Description

Duplicate entities means that they have same 'name', 'default value' and 'help message'.

Current generator can not deal with the duplicate entities in different groups. They will be added into the same group in tempest.conf.sample. As generator compares opt with the opts in groups to find the group in which the opt is, duplicate opts will be matched in the same group.

For example:
[network-feature-enabled] has 3 api_extensions in tempest.conf.sample. 2 of them should belong to [compute_features_group] and [volume_feature_group]. I reported a bug https://bugs.launchpad.net/tempest/+bug/1280085, and submit a patch making the dup entities different to fix it. But that's not the root cause.

Tags: config
Changed in tempest:
status: New → Confirmed
Mark Maglana (mmaglana)
Changed in tempest:
assignee: nobody → Mark Maglana (mmaglana)
Revision history for this message
Matthew Treinish (treinish) wrote :

This isn't a tempest bug, the sample generator is synced from oslo-incubator. This needs to be fixed in oslo then we can just update the copy in the tempest repo.

Changed in oslo:
status: New → Invalid
status: Invalid → New
Changed in tempest:
status: Confirmed → Invalid
Mark Maglana (mmaglana)
Changed in tempest:
assignee: Mark Maglana (mmaglana) → nobody
Ben Nemec (bnemec)
Changed in oslo:
status: New → Triaged
importance: Undecided → Medium
tags: added: config
Jon Grimm (jgrimm)
Changed in oslo:
assignee: nobody → Jon Grimm (jgrimm)
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

The simplest fix for this is likely to be to update tempest to use the new config generator in oslo.config instead of the one in the incubator. http://docs.openstack.org/developer/oslo.config/generator.html

Revision history for this message
Jon Grimm (jgrimm) wrote :

Thanks Doug. Indeed it looks like the new generator doesn't have this issue; added entry_points to tempest and then tested with some identical opts. Was able to see the bug behavior with the old generator and see desired behavior with the new generator.

Will polish this up for submission.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest (master)

Fix proposed to branch: master
Review: https://review.openstack.org/112111

Changed in tempest:
assignee: nobody → Jon Grimm (jgrimm)
status: Invalid → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo-incubator (master)

Fix proposed to branch: master
Review: https://review.openstack.org/112603

Changed in oslo:
status: Triaged → In Progress
affects: oslo-incubator → oslo.config
Revision history for this message
Jon Grimm (jgrimm) wrote :

invalidated oslo.config portion. not a problem there and tempest is moving to the new generator.

Changed in oslo.config:
status: In Progress → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tempest (master)

Reviewed: https://review.openstack.org/112111
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=270bd7f8cea90078c334ede3b2e113248a558117
Submitter: Jenkins
Branch: master

commit 270bd7f8cea90078c334ede3b2e113248a558117
Author: Jon Grimm <email address hidden>
Date: Tue Aug 5 18:11:29 2014 +0000

    Move tempest to oslo-config-generator

    Also fixes tempest reported bug with old generator in oslo-incubator,
    when identical options are registered in different groups.

    Change-Id: I274f48503c1b61ca09cabc8d8c50245ba1059943
    Closes-bug: 1282887

Changed in tempest:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.