Fix locking issues in Windows

[Pedro Navarro Pérez]

When attaching a volume the next error is occurred:

2013-03-11 21:43:29.921 ERROR cinder.openstack.common.rpc.common [req-946e0c80-f48a-431d-8848-997d993f4fce 4353ebfbc4764cd1882c0f336f73ae72 be2150f90f034291b2bbfcd72d7e4884] Returning exception an integer is required to caller
2013-03-11 21:43:29.921 ERROR cinder.openstack.common.rpc.common [req-946e0c80-f48a-431d-8848-997d993f4fce 4353ebfbc4764cd1882c0f336f73ae72 be2150f90f034291b2bbfcd72d7e4884] ['Traceback (most recent call last):\n', ' File "C:\\dev\\openstack\\cinder\\cinder\\openstack\\common\\rpc\\amqp.py", line 430, in _process_data\n rval = self.proxy.dispatch(ctxt, version, method, **args)\n', ' File "C:\\dev\\openstack\\cinder\\cinder\\openstack\\common\\rpc\\dispatcher.py", line 133, in dispatch\n return getattr(proxyobj, method)(ctxt, **kwargs)\n', ' File "C:\\dev\\openstack\\cinder\\cinder\\volume\\manager.py", line 536, in attach_volume\n return do_attach()\n', ' File "C:\\dev\\openstack\\cinder\\cinder\\openstack\\common\\lockutils.py", line 214, in inner\n with lock:\n', ' File "C:\\dev\\openstack\\cinder\\cinder\\openstack\\common\\lockutils.py", line 82, in __enter__\n self.trylock()\n', ' File "C:\\dev\\openstack\\cinder\\cinder\\openstack\\common\\lockutils.py", line 109, in trylock\n msvcrt.locking(self.lockfile, msvcrt.LK_NBLCK, 1)\n', 'TypeError: an integer is required\n']
2013-03-11 21:43:32.229 ERROR cinder.openstack.common.rpc.amqp [req-c4c420ae-df17-4009-aae3-bc6a7e9729b4 4353ebfbc4764cd1882c0f336f73ae72 be2150f90f034291b2bbfcd72d7e4884] Exception during message handling
2013-03-11 21:43:32.229 236 TRACE cinder.openstack.common.rpc.amqp Traceback (most recent call last):
2013-03-11 21:43:32.229 236 TRACE cinder.openstack.common.rpc.amqp File "C:\dev\openstack\cinder\cinder\openstack\common\rpc\amqp.py", line 430, in _process_data
2013-03-11 21:43:32.229 236 TRACE cinder.openstack.common.rpc.amqp rval = self.proxy.dispatch(ctxt, version, method, **args)
2013-03-11 21:43:32.229 236 TRACE cinder.openstack.common.rpc.amqp File "C:\dev\openstack\cinder\cinder\openstack\common\rpc\dispatcher.py", line 133, in dispatch
2013-03-11 21:43:32.229 236 TRACE cinder.openstack.common.rpc.amqp return getattr(proxyobj, method)(ctxt, **kwargs)
2013-03-11 21:43:32.229 236 TRACE cinder.openstack.common.rpc.amqp File "C:\dev\openstack\cinder\cinder\volume\manager.py", line 536, in attach_volume
2013-03-11 21:43:32.229 236 TRACE cinder.openstack.common.rpc.amqp return do_attach()
2013-03-11 21:43:32.229 236 TRACE cinder.openstack.common.rpc.amqp File "C:\dev\openstack\cinder\cinder\openstack\common\lockutils.py", line 214, in inner
2013-03-11 21:43:32.229 236 TRACE cinder.openstack.common.rpc.amqp with lock:
2013-03-11 21:43:32.229 236 TRACE cinder.openstack.common.rpc.amqp File "C:\dev\openstack\cinder\cinder\openstack\common\lockutils.py", line 82, in __enter__
2013-03-11 21:43:32.229 236 TRACE cinder.openstack.common.rpc.amqp self.trylock()
2013-03-11 21:43:32.229 236 TRACE cinder.openstack.common.rpc.amqp File "C:\dev\openstack\cinder\cinder\openstack\common\lockutils.py", line 109, in trylock
2013-03-11 21:43:32.229 236 TRACE cinder.openstack.common.rpc.amqp msvcrt.locking(self.lockfile, msvcrt.LK_NBLCK, 1)
2013-03-11 21:43:32.229 236 TRACE cinder.openstack.common.rpc.amqp TypeError: an integer is required

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/24156

[Alessandro Pilotti (alexpilotti)]

http://docs.python.org/2/library/msvcrt.html

The docs for msvcrt.locking() say that:

"Lock part of a file based on file descriptor fd from the C runtime."

We need to use fileno() for a file descriptor opened with open()

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/24162

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/24162
Committed: http://github.com/openstack/oslo-incubator/commit/21925b63af87c36be97eec5b212e06477471bb1e
Submitter: Jenkins
Branch: master

commit 21925b63af87c36be97eec5b212e06477471bb1e
Author: Pedro Navarro Perez <email address hidden>
Date: Tue Mar 12 04:24:51 2013 -0700

    Fix locking issues in Windows

    The Windows Storage Cinder plugin through
    the Windows Locks implementation
    of the InterProcessLock fails in
    attaching/detaching operations.

    Change-Id: I682205592e152b3222e04ca3221d25594d134dd9
    Fixes: bug #1153966

[Thierry Carrez (ttx)]

In nova master: https://review.openstack.org/#/c/25167/1
In nova grizzly-rc2: https://review.openstack.org/#/c/25277/