graduate.sh fails to delete openstack folder

[Abhishek Kekane]

graduate.sh script fails to delete openstack folder as it contains _i18.py in openstack/common folder.

script does not completes and shows error 'rmdir: failed to remove ‘openstack’: Directory not empty'

I am running script as per mentioned in
https://wiki.openstack.org/wiki/Oslo/CreatingANewLibrary#Graduating_a_Library_from_the_Incubator

Steps to reproduce:

1. git clone git://git.openstack.org/openstack/oslo-incubator
2. git clone git://git.openstack.org/openstack/oslo-incubator oslo.foo
3. cd oslo.foo
4. run graduate.sh as, ../oslo-incubator/tools/graduate.sh i18n openstack/common/cliutils.py

[Davanum Srinivas (DIMS) (dims-v)]

Fixing in https://review.openstack.org/#/c/237747/

[Abhishek Kekane (abhishek-kekane)]

when I try to move files from apiclient then it fails.

run graduate.sh as, ../oslo-incubator/tools/graduate.sh i18n openstack/common/apiclient/base.py

For moving files from common folder it works perfectly,

run graduate.sh as, ../oslo-incubator/tools/graduate.sh i18n openstack/common/cliutils.py

[Abhishek Kekane (abhishek-kekane)]

../oslo-incubator/tools/graduate.sh apiclient openstack/common/apiclient/auth.py openstack/common/apiclient/base.py openstack/common/apiclient/client.py openstack/common/apiclient/exceptions.py openstack/common/apiclient/fake_client.py openstack/common/apiclient/utils.py tests/unit/apiclient/test_auth.py tests/unit/apiclient/test_base.py tests/unit/apiclient/test_client.py tests/unit/apiclient/test_exceptions.py tests/unit/apiclient/test_utils.py

[Ankit Agrawal (ankitagrawal)]

I tried to reproduce this issue in my local environment and the failure looks related to the new library name in which directories and files to be saved.

When I try to move files into library named "apiclient" then it fails.
run graduate.sh as, ../oslo-incubator/tools/graduate.sh apiclient openstack/common/apiclient/auth.py openstack/common/_i18n.py

But when I try to move files into library named as "foo" or some other name then it woks fine.
run graduate.sh as, ../oslo-incubator/tools/graduate.sh foo openstack/common/apiclient/auth.py openstack/common/_i18n.py
or
 ../oslo-incubator/tools/graduate.sh i18n openstack/common/apiclient/auth.py openstack/common/_i18n.py

[Davanum Srinivas (DIMS) (dims-v)]

All code in oslo-incubator will be deleted soon.

http://markmail.org/message/kgdnukenoni3hbmw

thanks,
dims