Need to warn when both active and deprecated names for an option are found in the config file(s)

Bug #1319868 reported by Andrew Woodward
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.config
Fix Released
Wishlist
Unassigned

Bug Description

oslo.config options support depreciated parameters to help migrations between version, however in some cases the the natural location may have a default value in the consuming projects config file. In this case it is possible for a deployer to set the depreciated location and leave the default.

For example, this occurred in https://bugs.launchpad.net/fuel/+bug/1275943 (havana) and https://bugs.launchpad.net/fuel/+bug/1309780 (icehouse)

Speaking with @dhellmann, there should be a warning message in the event that this occurs

Tags: config
summary: - Using a depreciated parameter and the natural, no warning occurs
+ Using a deprecated parameter and the natural, no warning occurs
summary: - Using a deprecated parameter and the natural, no warning occurs
+ Need to warn when both active and deprecated names for an option are
+ found in the config file(s)
tags: added: config
Changed in oslo:
status: New → Triaged
importance: Undecided → Wishlist
Jon Grimm (jgrimm)
Changed in oslo:
assignee: nobody → Jon Grimm (jgrimm)
affects: oslo-incubator → oslo.config
Jon Grimm (jgrimm)
Changed in oslo.config:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.config (master)

Fix proposed to branch: master
Review: https://review.openstack.org/121691

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on oslo.config (master)

Change abandoned by Davanum Srinivas (dims) (<email address hidden>) on branch: master
Review: https://review.openstack.org/121691
Reason: This review is > 12 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Jon Grimm (jgrimm)
Changed in oslo.config:
status: In Progress → Confirmed
assignee: Jon Grimm (jgrimm) → nobody
Revision history for this message
Ben Nemec (bnemec) wrote :

We have been logging warnings when deprecated options are in use for a while now: https://github.com/openstack/oslo.config/blob/7072a7552dcb58a60d08c73c1d002fdf1c5a6202/oslo_config/cfg.py#L865

I think that addresses this bug. If not, feel free to reopen.

Changed in oslo.config:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.