log_handler miss some log information

Bug #1278291 reported by Tiantian Gao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Tiantian Gao
oslo-incubator
Fix Released
Medium
Tiantian Gao

Bug Description

log_handler:PublishErrorsHandler just emit the `msg` attribute of record. But many times we log with extra arguments, like "LOG.debug('start %s', blabla)", which will result in only show "start %s" in notification payload.

Tags: oslo
Tiantian Gao (gtt116)
Changed in oslo:
assignee: nobody → Tiantian Gao (gtt116)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo-incubator (master)

Fix proposed to branch: master
Review: https://review.openstack.org/72275

Changed in oslo:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/72275
Committed: https://git.openstack.org/cgit/openstack/oslo-incubator/commit/?id=1f1d3cd3230cb98dbf569bfab84f7cce0300ea22
Submitter: Jenkins
Branch: master

commit 1f1d3cd3230cb98dbf569bfab84f7cce0300ea22
Author: gtt116 <email address hidden>
Date: Mon Feb 10 06:46:35 2014 +0000

    Emit message which merged user-supplied argument in log_handler

    When using PublishErrorsHandler, it will missing user-supplied arguments.
    For example, do LOG.info("blabla %s", "foo"), the payload only contains
    "blabla %s", but we expect it like "blabla foo". This patch fix it.

    Change-Id: I91289cc4a60f5dab89bca852e6f52b4b83831e47
    Closes-bug: #1278291

Changed in oslo:
status: In Progress → Fix Committed
Changed in oslo:
milestone: none → icehouse-3
importance: Undecided → Medium
Tiantian Gao (gtt116)
Changed in nova:
assignee: nobody → Tiantian Gao (gtt116)
Revision history for this message
Matt Riedemann (mriedem) wrote :
tags: added: oslo
Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/75280
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1fb1b058211f08c0b993372e734ed62cd9267193
Submitter: Jenkins
Branch: master

commit 1fb1b058211f08c0b993372e734ed62cd9267193
Author: gtt116 <email address hidden>
Date: Fri Feb 21 09:52:55 2014 +0800

    Emit message which merged user-supplied argument in log_handler

    Sync from Oslo, change-id: I91289cc4a60f5dab89bca852e6f52b4b83831e47

    When using PublishErrorsHandler, it will missing user-supplied arguments.
    For example, do LOG.info("blabla %s", "foo"), the payload only contains
    "blabla %s", but we expect it like "blabla foo". This patch fix it.

    Change-Id: I375b0d83783b1866d3bf30ff3ade27e746bb856b
    Closes-bug: #1278291

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → icehouse-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo:
milestone: icehouse-3 → 2014.1
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.