| 2013-03-20 08:30:59 |
Zhongyue Luo |
description |
Currently there are some unused imports in the upstream codebase.
************* Module tests.utils
W: 20,0: Unused import subprocess
************* Module tests.unit.test_plugin
W: 18,0: Unused import cfg
************* Module tests.unit.test_notifier
W: 23,0: Unused import rabbit_notifier
************* Module tests.unit.test_version
...
Instead of conducting janitorial cleanups every now and then we should have pylint check for unused imports for each patch.
Therefore adding a python script that executes pylint and a pylint section to tox.ini should prevent unused imports perminantly.
The reason writing a script is for flexible configuration of pylint which could happen in the future. |
Currently there are some unused imports in the upstream codebase.
************* Module tests.utils
W: 20,0: Unused import subprocess
************* Module tests.unit.test_plugin
W: 18,0: Unused import cfg
************* Module tests.unit.test_notifier
W: 23,0: Unused import rabbit_notifier
************* Module tests.unit.test_version
...
Instead of conducting janitorial cleanups every now and then we should have pylint check for unused imports for each patch.
Therefore adding a python script that executes pylint and a pylint section to tox.ini should prevent unused imports perminantly.
The reason writing a script is for flexible configuration of pylint which would be useful for adding exceptions in the future. |
|
