test_get_cluster_group_type fails on 32 bits arch

[Thomas Goirand]

Hi,

Looks like this unit test fails on 32 bits arch (ie: i386 and armhf). Please see Debian bug report at:

https://bugs.debian.org/928129

======================================================================
FAIL: os_win.tests.unit.utils.compute.test_clusapi_utils.ClusApiUtilsTestCase.test_get_cluster_group_type
os_win.tests.unit.utils.compute.test_clusapi_utils.ClusApiUtilsTestCase.test_get_cluster_group_type
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "/build/python-os-win-4.2.0/os_win/tests/unit/utils/compute/test_clusapi_utils.py", line 619, in test_get_cluster_group_type
    ctypes.byref(prop_list), ctypes.sizeof(prop_list))
  File "/build/python-os-win-4.2.0/os_win/utils/compute/_clusapi_utils.py", line 442, in get_cluster_group_type
    w_const.CLUSPROP_SYNTAX_LIST_VALUE_DWORD)
  File "/build/python-os-win-4.2.0/os_win/utils/compute/_clusapi_utils.py", line 426, in get_prop_list_entry_value
    raise exceptions.ClusterPropertyListParsingError()
os_win.exceptions.ClusterPropertyListParsingError: Parsing a cluster property list failed.

Cheers,

Thomas

[Lucian Petrut (petrutlucian94)]

Thanks for filing this bug. Looks like one of the tests is using the wrong type, long long instead of long, which happens to be the same on x64.

I'll send a fix right away.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/708138

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/708138
Committed: https://git.openstack.org/cgit/openstack/os-win/commit/?id=a30eeb8ed9be1c97c459cf4aa53526a31e395613
Submitter: Zuul
Branch: master

commit a30eeb8ed9be1c97c459cf4aa53526a31e395613
Author: Lucian Petrut <email address hidden>
Date: Mon Feb 17 17:10:19 2020 +0200

    Trivial: Fix test_get_cluster_group_type on x86 or Win32

    One unit test is using the wrong type, unsigned long long instead of
    long, for which reason it will fail on Linux x86 or Windows, where
    the size of those types do not match.

    Change-Id: If49e57ada8d367f537710974ea59728d20720275
    Closes-Bug: 1850770

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-win 5.0.1 release.