WMI job terminate timeout is hardcoded

Bug #1790890 reported by Lucian Petrut
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
os-win
Fix Released
Undecided
Unassigned

Bug Description

We're using a hardcoded 15 seconds timeout when canceling WMI jobs.

Some jobs may not be cancelable, some may take longer to stop. For example, Nova instances may end up in error state after attempting to delete them as this hardcoded timeout gets exceeded.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-win (master)

Reviewed: https://review.openstack.org/600095
Committed: https://git.openstack.org/cgit/openstack/os-win/commit/?id=11e28563d4ffacfeb1a65b55b5fe792c61e7d0e4
Submitter: Zuul
Branch: master

commit 11e28563d4ffacfeb1a65b55b5fe792c61e7d0e4
Author: Lucian Petrut <email address hidden>
Date: Wed Sep 5 17:52:58 2018 +0300

    Add wmi job terminate timeout cfg opt

    We're using a hardcoded 15 seconds timeout when canceling WMI jobs.

    Some jobs may not be cancelable, some may take longer to stop. For
    example, Nova instances may end up in error state after attempting
    to delete them as this hardcoded timeout gets exceeded.

    That being considered, we're now adding a config option for this,
    also increasing the default timeout to 2 minutes.

    Ideally, Nova should pass a timeout here. Still, by adding a config
    option at the os-win level, it's easier to backport this to older
    releases, also providing a default for any kind of WMI job.

    Change-Id: I797366c40a3a4bb74fe925bd10697f227e22915c
    Closes-Bug: #1790890

Changed in os-win:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-win (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/607545

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-win (stable/rocky)

Reviewed: https://review.openstack.org/607545
Committed: https://git.openstack.org/cgit/openstack/os-win/commit/?id=fc4f6c916ce99d7f6ff9e38eb67fc78915983fa1
Submitter: Zuul
Branch: stable/rocky

commit fc4f6c916ce99d7f6ff9e38eb67fc78915983fa1
Author: Lucian Petrut <email address hidden>
Date: Wed Sep 5 17:52:58 2018 +0300

    Add wmi job terminate timeout cfg opt

    We're using a hardcoded 15 seconds timeout when canceling WMI jobs.

    Some jobs may not be cancelable, some may take longer to stop. For
    example, Nova instances may end up in error state after attempting
    to delete them as this hardcoded timeout gets exceeded.

    That being considered, we're now adding a config option for this,
    also increasing the default timeout to 2 minutes.

    Ideally, Nova should pass a timeout here. Still, by adding a config
    option at the os-win level, it's easier to backport this to older
    releases, also providing a default for any kind of WMI job.

    Change-Id: I797366c40a3a4bb74fe925bd10697f227e22915c
    Closes-Bug: #1790890
    (cherry picked from commit 11e28563d4ffacfeb1a65b55b5fe792c61e7d0e4)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-win (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/607866

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-win (stable/queens)

Reviewed: https://review.openstack.org/607866
Committed: https://git.openstack.org/cgit/openstack/os-win/commit/?id=e312c5806da39a2ac87b24ce57de0a6d1ca6e52c
Submitter: Zuul
Branch: stable/queens

commit e312c5806da39a2ac87b24ce57de0a6d1ca6e52c
Author: Lucian Petrut <email address hidden>
Date: Wed Sep 5 17:52:58 2018 +0300

    Add wmi job terminate timeout cfg opt

    We're using a hardcoded 15 seconds timeout when canceling WMI jobs.

    Some jobs may not be cancelable, some may take longer to stop. For
    example, Nova instances may end up in error state after attempting
    to delete them as this hardcoded timeout gets exceeded.

    That being considered, we're now adding a config option for this,
    also increasing the default timeout to 2 minutes.

    Ideally, Nova should pass a timeout here. Still, by adding a config
    option at the os-win level, it's easier to backport this to older
    releases, also providing a default for any kind of WMI job.

    Change-Id: I797366c40a3a4bb74fe925bd10697f227e22915c
    Closes-Bug: #1790890
    (cherry picked from commit 11e28563d4ffacfeb1a65b55b5fe792c61e7d0e4)
    (cherry picked from commit fc4f6c916ce99d7f6ff9e38eb67fc78915983fa1)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-win 4.1.0

This issue was fixed in the openstack/os-win 4.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-win queens-eol

This issue was fixed in the openstack/os-win queens-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-win rocky-eol

This issue was fixed in the openstack/os-win rocky-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.