Not all *Utils classes have the same interface as their parent classes

Bug #1746986 reported by Claudiu Belu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
os-win
Fix Released
Low
Unassigned

Bug Description

Some Utils classes (e.g.: VMUtils10) does not have the same interface as their parents.

This can cause minor issues when testing with autospecs.

Claudiu Belu (cbelu)
Changed in os-win:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-win (master)

Reviewed: https://review.openstack.org/540369
Committed: https://git.openstack.org/cgit/openstack/os-win/commit/?id=ea65d0a5105d0a1e258cd26f653fef91b6336746
Submitter: Zuul
Branch: master

commit ea65d0a5105d0a1e258cd26f653fef91b6336746
Author: Claudiu Belu <email address hidden>
Date: Wed Jan 31 00:35:41 2018 -0800

    Ensures that all classes have the same interface as their parents

    VMUtils10 has a few extra methods when compared to VMUtils. This
    patch adds those methods to VMUtils (raising NotImplementedError).

    Adds unit test that checks for future inconsistentcies.

    ISCSIInitiatorCLIUtils has been deprecated and removed, but it was
    not removed from utilsfactory.utils_map. This patch addresses this
    issue.

    Closes-Bug: #1746986

    Change-Id: I2a963304fc67595bc18e719e6b4420f553519c41

Changed in os-win:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-win 4.0.0

This issue was fixed in the openstack/os-win 4.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-win (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/558729

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-win (stable/queens)

Reviewed: https://review.openstack.org/558729
Committed: https://git.openstack.org/cgit/openstack/os-win/commit/?id=eb9310f7689f2288dc3acaf68f62e632ab4570d1
Submitter: Zuul
Branch: stable/queens

commit eb9310f7689f2288dc3acaf68f62e632ab4570d1
Author: Claudiu Belu <email address hidden>
Date: Wed Jan 31 00:35:41 2018 -0800

    Ensures that all classes have the same interface as their parents

    VMUtils10 has a few extra methods when compared to VMUtils. This
    patch adds those methods to VMUtils (raising NotImplementedError).

    Adds unit test that checks for future inconsistentcies.

    ISCSIInitiatorCLIUtils has been deprecated and removed, but it was
    not removed from utilsfactory.utils_map. This patch addresses this
    issue.

    (cherry-picked from commit ea65d0a5105d0a1e258cd26f653fef91b6336746)

    Closes-Bug: #1746986

    Change-Id: I2a963304fc67595bc18e719e6b4420f553519c41

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-win queens-eol

This issue was fixed in the openstack/os-win queens-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.