Cluster resource group migration issue

[Lucian Petrut]

At the moment, in order to migrate a clustered VM, we move the according cluster resource group using the MoveToNewNodeParams WMI method. This method accepts an undocumented 'Parameters' argument, which is then passed to the underlying MoveClusterGroupEx clusapi.dll function. While the latter expects a property list as described here: https://msdn.microsoft.com/en-us/library/aa371809(v=vs.85).aspx, we were passing the desired migration type directly.

This worked on Windows Server 2012R2 but is causing issues on WS 2016. Resource group end up hanging in a 'Pending' state.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/361136
Committed: https://git.openstack.org/cgit/openstack/os-win/commit/?id=f3de712905b7e784d5cfa061cbf9a27215a43391
Submitter: Jenkins
Branch: master

commit f3de712905b7e784d5cfa061cbf9a27215a43391
Author: Lucian Petrut <email address hidden>
Date: Fri Aug 26 13:18:08 2016 +0300

    Fix clustered vm live migration

    At the moment, in order to migrate a clustered VM, we move the
    according cluster resource group using the MoveToNewNodeParams WMI
    method. This method accepts an undocumented 'Parameters' argument,
    which is then passed to the underlying MoveClusterGroupEx clusapi.dll
    function.

    While the latter expects a property list as described at the following
    link, we were passing the desired migration type directly.
    https://msdn.microsoft.com/en-us/library/aa371809(v=vs.85).aspx

    This worked on Windows Server 2012R2 but is causing issues on WS 2016.
    Resource group end up hanging in a 'Pending' state.

    This change addresses this issue by using clusapi.dll functions directly,
    as the according WMI methods are not working, throwing a generic error
    even though the VMs are migrated properly.

    Closes-Bug: #1618425

    Change-Id: Idfcd3505cbbf2754addeba4f1ebeb880f3b9a56b

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/375598

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/375598
Committed: https://git.openstack.org/cgit/openstack/os-win/commit/?id=a78531b66e2f8f6118811e764076129ab6537fd3
Submitter: Jenkins
Branch: stable/newton

commit a78531b66e2f8f6118811e764076129ab6537fd3
Author: Lucian Petrut <email address hidden>
Date: Fri Aug 26 13:18:08 2016 +0300

    Fix clustered vm live migration

    At the moment, in order to migrate a clustered VM, we move the
    according cluster resource group using the MoveToNewNodeParams WMI
    method. This method accepts an undocumented 'Parameters' argument,
    which is then passed to the underlying MoveClusterGroupEx clusapi.dll
    function.

    While the latter expects a property list as described at the following
    link, we were passing the desired migration type directly.
    https://msdn.microsoft.com/en-us/library/aa371809(v=vs.85).aspx

    This worked on Windows Server 2012R2 but is causing issues on WS 2016.
    Resource group end up hanging in a 'Pending' state.

    This change addresses this issue by using clusapi.dll functions directly,
    as the according WMI methods are not working, throwing a generic error
    even though the VMs are migrated properly.

    Closes-Bug: #1618425

    Change-Id: Idfcd3505cbbf2754addeba4f1ebeb880f3b9a56b
    (cherry picked from commit f3de712905b7e784d5cfa061cbf9a27215a43391)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-win 1.2.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-win 1.3.0 release.