nova unit tests failing with os-win 0.1.0

[Matt Riedemann]

2016-01-12 16:30:52.921 | Captured traceback:
2016-01-12 16:30:52.921 | ~~~~~~~~~~~~~~~~~~~
2016-01-12 16:30:52.921 | Traceback (most recent call last):
2016-01-12 16:30:52.921 | File "nova/tests/unit/virt/hyperv/test_imagecache.py", line 59, in setUp
2016-01-12 16:30:52.921 | self.imagecache = imagecache.ImageCache()
2016-01-12 16:30:52.922 | File "nova/virt/hyperv/imagecache.py", line 39, in __init__
2016-01-12 16:30:52.922 | self._pathutils = pathutils.PathUtils()
2016-01-12 16:30:52.922 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/os_win/utils/pathutils.py", line 46, in __init__
2016-01-12 16:30:52.922 | super(PathUtils, self).__init__()
2016-01-12 16:30:52.922 | File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/os_win/utils/storage/smbutils.py", line 35, in __init__
2016-01-12 16:30:52.922 | self._smb_conn = wmi.WMI(moniker=r"root\Microsoft\Windows\SMB")
2016-01-12 16:30:52.922 | NameError: global name 'wmi' is not defined

https://jenkins05.openstack.org/job/gate-nova-python27/15232/console

os-win 0.1.0 was released today which is causing the regression:

http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22NameError%3A%20global%20name%20'wmi'%20is%20not%20defined%5C%22%20AND%20tags%3A%5C%22console%5C%22

[Matt Riedemann (mriedem)]

g-r block is here: https://review.openstack.org/266490

[Matt Riedemann (mriedem)]

There is a nova patch proposed here: https://review.openstack.org/#/c/266495/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/266505
Committed: https://git.openstack.org/cgit/openstack/os-win/commit/?id=0afac9d789de699d87e950955a9c5fd914ce3ae7
Submitter: Jenkins
Branch: master

commit 0afac9d789de699d87e950955a9c5fd914ce3ae7
Author: Claudiu Belu <email address hidden>
Date: Tue Jan 12 19:29:50 2016 +0200

    Avoid initializing WMI connections on Linux

    Nova unit tests are failing due to a WMI connection
    initialization on Linux. WMI is a Windows specific
    module.

    Change-Id: I67bf08517707e992f45045511350a884faf260f2
    Closes-Bug: #1533290

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/266495
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6248dd0ae5ed16a690dfb34909e82f1ee49b4b3e
Submitter: Jenkins
Branch: master

commit 6248dd0ae5ed16a690dfb34909e82f1ee49b4b3e
Author: Claudiu Belu <email address hidden>
Date: Tue Jan 12 09:19:14 2016 -0800

    Fixes Hyper-V unit tests for latest os_win release

    os_win release 0.1.0 causes unit tests to fail, as the wmi
    module does not exist. Mocking it will fix the issue.

    Change-Id: Iad91cd280e04db0000b58e1194350489b2044506
    Closes-Bug: #1533290

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/nova 13.0.0.0b2 development milestone.