os-vif

Remove IP proxy methods

Bug #1817940 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
os-vif
Fix Released
Undecided
Rodolfo Alonso

Bug Description

Remove IP proxy methods in os_vif.internal.command.ip.__init__.py. Both Windows and Linux IP implementations have the same interface, IpCommand. Method calls (set, add, delete, exists) must be the same for both IP classes, making those proxy calls unnecessary.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-vif (master)

Fix proposed to branch: master
Review: https://review.openstack.org/643115

Changed in os-vif:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.opendev.org/655695

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on os-vif (master)

Change abandoned by Rodolfo Alonso Hernandez (<email address hidden>) on branch: master
Review: https://review.opendev.org/643115
Reason: Sorry folks, this patch is stuck in the gate. The same patch is in https://review.opendev.org/#/c/655695/, only rebased and with different change-id

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-vif (master)

Reviewed: https://review.opendev.org/655695
Committed: https://git.openstack.org/cgit/openstack/os-vif/commit/?id=ee124d2e98c2660ced7d71c1bd10525bf095a939
Submitter: Zuul
Branch: master

commit ee124d2e98c2660ced7d71c1bd10525bf095a939
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Mar 13 17:56:18 2019 +0000

    Remove IP proxy methods

    Remove IP proxy methods in os_vif.internal.command.ip.__init__.py. Both
    Windows and Linux IP implementations have the same interface, IpCommand.
    Method calls (set, add, delete, exists) must be the same for both IP
    classes, making those proxy calls unnecessary.

    Removed a nesting level for internal IP commands. Now those commands are
    located in os_vif.internal.ip.

    Change-Id: Id8b71172fb06b435cf169a7e55c11233f22fa65b
    Closes-Bug: #1817940

Changed in os-vif:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/os-vif 1.16.0

This issue was fixed in the openstack/os-vif 1.16.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.